Skip to content

stop cloud(mix) recording when there is only one user in the call #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: preprod
Choose a base branch
from
Open

stop cloud(mix) recording when there is only one user in the call #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6397cc
stop cloud(mix) recording when there is only one user in the call
SupriyaAdep Oct 16, 2024
7a286cd
disable auto start recording
SupriyaAdep Oct 25, 2024
28c6cf2
recording mode mix
SupriyaAdep Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"PRECALL": true,
"CHAT": true,
"CLOUD_RECORDING": true,
"RECORDING_MODE": "WEB",
"RECORDING_MODE": "MIX",
"SCREEN_SHARING": true,
"LANDING_SUB_HEADING": "The Real-Time Engagement Platform",
"ENCRYPTION_ENABLED": true,
Expand Down Expand Up @@ -93,6 +93,6 @@
"CHAT_URL": "https://a41.chat.agora.io",
"ENABLE_NOISE_CANCELLATION_BY_DEFAULT": true,
"DISABLE_LANDSCAPE_MODE": false,
"STT_AUTO_START": true,
"CLOUD_RECORDING_AUTO_START": true
"STT_AUTO_START": false,
"CLOUD_RECORDING_AUTO_START": false
}
27 changes: 27 additions & 0 deletions template/src/subComponents/recording/useRecording.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,33 @@ const RecordingProvider = (props: RecordingProviderProps) => {
_stopRecording,
]);

useEffect(() => {
return () => {
if (recordingMode === 'MIX' && isRecordingActive) {
const totalUsers = hostUids?.length + audienceUids?.length;
logger.log(
LogSource.Internals,
'RECORDING',
'checking if you should stop recording on component unmount',
{
recordingMode,
isRecordingActive,
users: totalUsers,
},
);
if (totalUsers === 1) {
logger.log(
LogSource.Internals,
'RECORDING',
'stopping cloud(mix) recording as there is no user in the call',
);
stopRecording();
}
}
};
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

// auto start recording
useEffect(() => {
if (
Expand Down