Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support 4.5.0 #1228

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: support 4.5.0 #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6899c7
chore: optimize
guoxianzhe Sep 18, 2024
f9eb008
build(deps): bump express from 4.19.2 to 4.21.0 in /example (#1224)
dependabot[bot] Sep 27, 2024
19aa67f
chore: config terra and iris to 4.5.0
guoxianzhe Sep 27, 2024
9af0542
[AUTO] Generate codes by terra (#1226)
sda-rob Sep 27, 2024
5166409
[AUTO] Generate codes by terra (#1227)
sda-rob Sep 27, 2024
6c660e0
chore: optimize
guoxianzhe Sep 27, 2024
46ac396
chore: migrate abr feature
guoxianzhe Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ runs:
if: ${{ inputs.skip_install == 'false' }}
run: |
yarn config set agora-electron-sdk-pre-built 0
yarn install --frozen-lockfile
yarn install
yarn patch-package
shell: bash
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- name: Typecheck files
run: |
yarn example install --frozen-lockfile
yarn example install
yarn typecheck

build:
Expand Down
4 changes: 2 additions & 2 deletions example/src/renderer/examples/advanced/ScreenShare/ScreenShare.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@
ScreenCaptureSourceType.ScreencapturesourcetypeScreen
) {
this.engine?.startScreenCaptureByDisplayId(
targetSource.sourceId,
targetSource.sourceId!,
{},
{
dimensions: { width, height },
Expand All @@ -208,7 +208,7 @@
);
} else {
this.engine?.startScreenCaptureByWindowId(
targetSource.sourceId,
targetSource.sourceId!,
{},
{
dimensions: { width, height },
Expand Down Expand Up @@ -541,7 +541,7 @@
};
})}
value={excludeWindowList}
onValueChange={(value, index) => {

Check warning on line 544 in example/src/renderer/examples/advanced/ScreenShare/ScreenShare.tsx

View workflow job for this annotation

GitHub Actions / lint 

'index' is defined but never used. Allowed unused args must match /^_/u
if (excludeWindowList.indexOf(value) === -1) {
this.setState((preState) => {
return {
Expand Down
Loading
Loading