fix: Wait for the executor.dispose done before exit the isolate #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We send a
null
to the sub isolate the clean up the native resources(destroyNativeApiEngine
...), but we do not wait for the clean-up logic to be finished, which will cause an error if we want to clean up something relative to the native resources right after thedispose
function in sychronize way. For example the test cases from theagora_rtc_engine
https://github.com/AgoraIO-Extensions/Agora-Flutter-SDK/blob/main/test_shard/fake_test_app/integration_test/apis_call_fake_test.dart