fix Node binary incompatibility #155
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
reviewed
Apr 23, 2024
| @@ -35,7 +35,11 @@ const fixupProposal = (proposal: ProposalInfo) => { | |||
|
|
|||
| // refresh install | |||
| execSync('rm -rf node_modules', { cwd: proposalPath }); | |||
| execSync('yarn install', { cwd: proposalPath }); | |||
| // install to update yarn.lock and get importable typed modules but | |||
| // skip building because the proposal never runs on the local filesystem. | |||
There was a problem hiding this comment.
my mental model is missing something...
What provides the binaries when the proposal runs?
There was a problem hiding this comment.
node_modules in the Docker image. It's already there. I had hoped that the mount would only be an overlay, but that was wrong. With mounting there's no way around running yarn install inside the container. I'll try to automate that so the developer doesn't have to remember/know.
|
I replaced one I then ran details |
|
If I do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #151
Test plan
I ran the updated doctor locally and confirmed there's no
.nodefile.I haven't yet tested with
test --debugbecause my env is running into a different problem missing--no-validate. @Chris-Hibbert can you confirm this fixes #151? (e.g. copy this changea3p-integration/node_modules/@agoric/synthetic-chain/dist/cli/cli.jsthen runyarn doctorand thenyarn test --debug -m upgrade-next)