feat(synthetic-chain): allow overriding Docker repo/tag #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig/synthetic-chain-overrides
branch
from
2b60595
to
4ff1ddc
Compare
turadg
reviewed
Sep 9, 2024
Comment on lines
+26
to
31
| repositoryColon: 'ghcr.io/agoric/agoric-3-proposals:', | ||
| sdkRepositoryColon: 'ghcr.io/agoric/agoric-sdk:', | ||
| platforms: null, | ||
| ag0FromTag: 'agoric-upgrade-7-2', | ||
| ag0RepositoryColon: 'ghcr.io/agoric/ag0:', | ||
| }; |
There was a problem hiding this comment.
what motivates having all these parameterized?
There was a problem hiding this comment.
Having a single source of truth. It felt icky to parameterise just the two I needed.
There was a problem hiding this comment.
There was already a single source for the ag0 cases. It was the dockerfile. Those values can't ever change either.
I'm going to noodle on how to do this more cleanly
|
Irrelevant, after biting the bullet in Agoric/agoric-sdk#10083 and modifying input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumb in the default repository and tag names from the top level build defaults and buildConfig, which can also be overridden during Docker build or bake.