10011 restore addAsset tests (#10058)

closes: #10011

## Description

9e15cb4 removed `addAssets.test.ts` because the bundle was failing to install after elideComments.

The cause was ordering effects. This fixes them by making the tests serial. It also makes it so some tests can pass if they're not all run.

### Security Considerations
none

### Scaling Considerations
none

### Documentation Considerations
none

### Testing Considerations
CI

### Upgrade Considerations
none

packages/boot/test/bootstrapTests/addAssets.test.ts

@@ -0,0 +1,198 @@
+/**
+ * @file tests of adding an asset to the vaultFactory.
+ * Checks that auctions update correctly.
+ */
+import { test as anyTest } from '@agoric/zoe/tools/prepare-test-env-ava.js';
+
+import type { TestFn } from 'ava';
+
+import { TimeMath } from '@agoric/time';
+import {
+  LiquidationTestContext,
+  makeLiquidationTestContext,
+} from '../../tools/liquidation.js';
+import { makeProposalExtractor } from '../../tools/supports.js';
+
+const test = anyTest as TestFn<
+  LiquidationTestContext & {
+    getCollateralProposal: (
+      name: string,
+      id: string,
+    ) => Awaited<ReturnType<ReturnType<typeof makeProposalExtractor>>>;
+    getNumAuctionBooks: () => number;
+  }
+>;
+
+const auctioneerPath = 'published.auction';
+
+test.before(async t => {
+  const context = await makeLiquidationTestContext(t);
+  const proposal = await context.buildProposal(
+    '@agoric/builders/scripts/inter-protocol/add-STARS.js',
+  );
+
+  const getCollateralProposal = (name, id) => {
+    // stringify, modify and parse because modifying a deep copy was fragile.
+    const proposalJSON = JSON.stringify(proposal);
+    const proposalMod = proposalJSON
+      .replaceAll('STARS', name)
+      .replaceAll('ibc/987C17B1', `ibc/987C17B1${id}`);
+    return JSON.parse(proposalMod);
+  };
+
+  const getNumAuctionBooks = () =>
+    Array.from(context.storage.data.keys()).filter(k =>
+      k.startsWith(`${auctioneerPath}.book`),
+    ).length;
+
+  t.context = {
+    ...context,
+    getCollateralProposal,
+    getNumAuctionBooks,
+  };
+});
+
+test.after.always(t => {
+  return t.context.shutdown && t.context.shutdown();
+});
+
+test.serial('addAsset to quiescent auction', async t => {
+  const { advanceTimeTo, evalProposal, getNumAuctionBooks, readLatest } =
+    t.context;
+
+  const booksBefore = getNumAuctionBooks();
+
+  await evalProposal(t.context.getCollateralProposal('COMETS', 'A'));
+
+  const { EV } = t.context.runUtils;
+
+  const auctioneerKit = await EV.vat('bootstrap').consumeItem('auctioneerKit');
+  const schedules = await EV(auctioneerKit.creatorFacet).getSchedule();
+  const { liveAuctionSchedule, nextAuctionSchedule } = schedules;
+  const nextEndTime = liveAuctionSchedule
+    ? liveAuctionSchedule.endTime
+    : nextAuctionSchedule!.endTime;
+  const fiveMinutes = harden({
+    relValue: 5n * 60n,
+    timerBrand: nextEndTime.timerBrand,
+  });
+  const nextQuiescentTime = TimeMath.addAbsRel(nextEndTime, fiveMinutes);
+  await advanceTimeTo(nextQuiescentTime);
+
+  const booksAfter = getNumAuctionBooks();
+  t.is(booksAfter, booksBefore + 1);
+
+  t.like(
+    readLatest(`${auctioneerPath}.book${booksAfter - 1}`),
+    {
+      currentPriceLevel: null,
+    },
+    'quiescent',
+  );
+});
+
+test.serial('addAsset to active auction', async t => {
+  const { advanceTimeTo, getNumAuctionBooks, readLatest } = t.context;
+  const { EV } = t.context.runUtils;
+
+  const booksBefore = getNumAuctionBooks();
+
+  t.like(
+    readLatest(`${auctioneerPath}.book${booksBefore - 1}`),
+    {
+      startPrice: null,
+    },
+    'active',
+  );
+
+  const auctioneerKit = await EV.vat('bootstrap').consumeItem('auctioneerKit');
+  const schedules = await EV(auctioneerKit.creatorFacet).getSchedule();
+  const { nextAuctionSchedule } = schedules;
+  assert(nextAuctionSchedule);
+  const nextStartTime = nextAuctionSchedule.startTime;
+  const fiveMinutes = harden({
+    relValue: 5n * 60n,
+    timerBrand: nextStartTime.timerBrand,
+  });
+  const futureBusyTime = TimeMath.addAbsRel(nextStartTime, fiveMinutes);
+
+  await advanceTimeTo(futureBusyTime);
+
+  t.log('launching proposal');
+
+  const proposal = t.context.getCollateralProposal('PLANETS', 'B');
+  const bridgeMessage = {
+    type: 'CORE_EVAL',
+    evals: proposal.evals,
+  };
+  t.log({ bridgeMessage });
+
+  const coreEvalBridgeHandler = await EV.vat('bootstrap').consumeItem(
+    'coreEvalBridgeHandler',
+  );
+  // XXX races with the following lines
+  void EV(coreEvalBridgeHandler).fromBridge(bridgeMessage);
+
+  const nextEndTime = nextAuctionSchedule!.endTime;
+  const afterEndTime = TimeMath.addAbsRel(nextEndTime, fiveMinutes);
+  await advanceTimeTo(afterEndTime);
+  t.log('proposal executed');
+
+  const schedulesAfter = await EV(auctioneerKit.creatorFacet).getSchedule();
+  // TimeMath.compareAbs() can't handle brands processed by kmarshall
+  t.truthy(
+    schedules.nextAuctionSchedule!.endTime.absValue <
+      schedulesAfter.nextAuctionSchedule!.endTime.absValue,
+  );
+
+  const booksAfter = getNumAuctionBooks();
+  t.is(booksAfter, booksBefore + 1);
+});
+
+test.serial('addAsset to auction starting soon', async t => {
+  const { advanceTimeTo, getNumAuctionBooks } = t.context;
+  const { EV } = t.context.runUtils;
+  const booksBefore = getNumAuctionBooks();
+
+  const auctioneerKit = await EV.vat('bootstrap').consumeItem('auctioneerKit');
+  const schedules = await EV(auctioneerKit.creatorFacet).getSchedule();
+  const { nextAuctionSchedule } = schedules;
+  assert(nextAuctionSchedule);
+  const nextStartTime = nextAuctionSchedule.startTime;
+  const fiveMinutes = harden({
+    relValue: 5n * 60n,
+    timerBrand: nextStartTime.timerBrand,
+  });
+  const tooCloseTime = TimeMath.subtractAbsRel(nextStartTime, fiveMinutes);
+
+  await advanceTimeTo(tooCloseTime);
+
+  const proposal = t.context.getCollateralProposal('MOONS', 'C');
+  t.log('launching proposal');
+  const bridgeMessage = {
+    type: 'CORE_EVAL',
+    evals: proposal.evals,
+  };
+  t.log({ bridgeMessage });
+
+  const coreEvalBridgeHandler = await EV.vat('bootstrap').consumeItem(
+    'coreEvalBridgeHandler',
+  );
+  // XXX races with the following lines
+  void EV(coreEvalBridgeHandler).fromBridge(bridgeMessage);
+
+  const nextEndTime = nextAuctionSchedule.endTime;
+  const afterEndTime = TimeMath.addAbsRel(nextEndTime, fiveMinutes);
+  await advanceTimeTo(afterEndTime);
+
+  t.log('proposal executed');
+
+  const schedulesAfter = await EV(auctioneerKit.creatorFacet).getSchedule();
+  t.truthy(
+    schedules.nextAuctionSchedule!.endTime.absValue <
+      schedulesAfter.nextAuctionSchedule!.endTime.absValue,
+  );
+
+  const booksAfter = getNumAuctionBooks();
+  t.is(booksAfter, booksBefore + 1);
+});