chore: add details to rights conservation assertion msg

for help diagnosing #4407
Agoric · Feb 11, 2022 · 10a5805 · 10a5805
1 parent 27271cd
commit 10a5805
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/packages/zoe/src/contractFacet/rightsConservation.js b/packages/zoe/src/contractFacet/rightsConservation.js
@@ -79,7 +79,7 @@ const assertEqualPerBrand = (leftSumsByBrand, rightSumsByBrand) => {
     const { leftSum, rightSum } = getSums(brand);
     assert(
       AmountMath.isEqual(leftSum, rightSum),
-      X`rights were not conserved for brand ${brand}`,
+      X`rights were not conserved for brand ${brand} ${leftSum.value} != ${rightSum.value}`,
     );
   });
 };

diff --git a/packages/zoe/test/unitTests/contracts/test-otcDesk.js b/packages/zoe/test/unitTests/contracts/test-otcDesk.js
@@ -261,7 +261,7 @@ const makeBob = (
 
       await t.throwsAsync(() => E(seat).getOfferResult(), {
         message:
-          'rights were not conserved for brand "[Alleged: simoleans brand]"',
+          'rights were not conserved for brand "[Alleged: simoleans brand]" "[15n]" != "[16n]"',
       });
 
       await assertPayoutAmount(

diff --git a/packages/zoe/test/unitTests/zcf/test-zoeHelpersWZcf.js b/packages/zoe/test/unitTests/zcf/test-zoeHelpersWZcf.js
@@ -459,7 +459,8 @@ test(`zoeHelper w/zcf - swapExact w/shortage`, async t => {
   );
 
   t.throws(() => swapExact(zcf, zcfSeatA, zcfSeatB), {
-    message: 'rights were not conserved for brand "[Alleged: moola brand]"',
+    message:
+      'rights were not conserved for brand "[Alleged: moola brand]" "[15n]" != "[20n]"',
   });
   t.truthy(zcfSeatA.hasExited(), 'fail right');
   await assertPayoutAmount(
@@ -515,7 +516,8 @@ test(`zoeHelper w/zcf - swapExact w/excess`, async t => {
   );
 
   t.throws(() => swapExact(zcf, zcfSeatA, zcfSeatB), {
-    message: 'rights were not conserved for brand "[Alleged: moola brand]"',
+    message:
+      'rights were not conserved for brand "[Alleged: moola brand]" "[40n]" != "[20n]"',
   });
   t.truthy(zcfSeatA.hasExited(), 'fail right');
   await assertPayoutAmount(
@@ -571,7 +573,8 @@ test(`zoeHelper w/zcf - swapExact w/extra payments`, async t => {
   );
 
   t.throws(() => swapExact(zcf, zcfSeatA, zcfSeatB), {
-    message: 'rights were not conserved for brand "[Alleged: moola brand]"',
+    message:
+      'rights were not conserved for brand "[Alleged: moola brand]" "[40n]" != "[0n]"',
   });
   t.truthy(zcfSeatA.hasExited(), 'fail right');
   await assertPayoutAmount(