Skip to content

Commit

Permalink
chore: remove deposit() from Cosmos acct interface
Browse files Browse the repository at this point in the history
  • Loading branch information
turadg committed Jun 4, 2024
1 parent ab9e449 commit 19bc874
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 14 deletions.
2 changes: 0 additions & 2 deletions packages/orchestration/src/cosmos-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,6 @@ export interface IcaAccount {
msgs: AnyJson[],
opts?: Partial<Omit<TxBody, 'messages'>>,
) => Promise<string>;
/** deposit payment from zoe to the account*/
deposit: (payment: Payment) => Promise<void>;
/** get Purse for a brand to .withdraw() a Payment from the account */
getPurse: (brand: Brand) => Promise<Purse>;
/**
Expand Down
13 changes: 3 additions & 10 deletions packages/orchestration/src/exos/chainAccountKit.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
/** @file ChainAccount exo */
import { NonNullish } from '@agoric/assert';
import { PurseShape } from '@agoric/ertp';
import { makeTracer } from '@agoric/internal';
import { V as E } from '@agoric/vow/vat.js';
import { M } from '@endo/patterns';
import { PaymentShape, PurseShape } from '@agoric/ertp';
import { findAddressField } from '../utils/address.js';
import {
ConnectionHandlerI,
ChainAddressShape,
ConnectionHandlerI,
Proto3Shape,
} from '../typeGuards.js';
import { findAddressField } from '../utils/address.js';
import { makeTxPacket, parseTxPacket } from '../utils/packet.js';

/**
Expand Down Expand Up @@ -40,7 +40,6 @@ export const ChainAccountI = M.interface('ChainAccount', {
.optional(M.record())
.returns(M.promise()),
close: M.callWhen().returns(M.undefined()),
deposit: M.callWhen(PaymentShape).returns(M.undefined()),
getPurse: M.callWhen().returns(PurseShape),
});

Expand Down Expand Up @@ -136,12 +135,6 @@ export const prepareChainAccountKit = zone =>
if (!connection) throw Fail`connection not available`;
await E(connection).close();
},
async deposit(payment) {
console.log('deposit got', payment);
console.error(
'FIXME deposit noop until https://github.com/Agoric/agoric-sdk/issues/9193',
);
},
/**
* get Purse for a brand to .withdraw() a Payment from the account
*
Expand Down
6 changes: 4 additions & 2 deletions packages/orchestration/src/exos/cosmosOrchestrationAccount.js
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,10 @@ export const prepareCosmosOrchestrationAccountKit = (
expect(result, trivialDelegateResponse, 'MsgDelegateResponse');
},
async deposit(payment) {
const { helper } = this.facets;
return E(helper.owned()).deposit(payment);
trace('deposit', payment);
console.error(
'FIXME deposit noop until https://github.com/Agoric/agoric-sdk/issues/9193',
);
},
async getBalances() {
throw Error('not yet implemented');
Expand Down

0 comments on commit 19bc874

Please sign in to comment.