Skip to content

Commit

Permalink
compat for NPM lifecycle scripts (#9262)
Browse files Browse the repository at this point in the history
closes: #8288

## Description

ui-kit was recently bumped to Yarn 4 and @samsiegart hit a snag that
required patching :
Agoric/ui-kit@464f61d

This removes `yarn` dependence in [NPM lifecycle
scripts](https://docs.npmjs.com/cli/v10/using-npm/scripts#life-cycle-operation-order).
It does so by using `npm run`, which should be available everywhere. In
Node 22 we'll [have `node
--run`](nodejs/corepack#57 (comment))
available.

### Security Considerations

none
### Scaling Considerations

none

### Documentation Considerations

none
### Testing Considerations

working in
Agoric/ui-kit@464f61d

### Upgrade Considerations

none
  • Loading branch information
mergify[bot] committed Apr 23, 2024
2 parents 4c65fc2 + 3f64e43 commit 3f2b479
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/cosmic-proto/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"!CHANGELOG.md"
],
"scripts": {
"build": "yarn tsc --project tsconfig.build.json",
"build": "tsc --project tsconfig.build.json",
"clean": "rimraf dist",
"codegen": "yarn protos-update && node scripts/codegen.cjs",
"prepare": "npm run build",
Expand Down
2 changes: 1 addition & 1 deletion packages/xsnap/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"build:env": "node src/build.js --show-env > build.env",
"build:from-env": "{ cat build.env; echo node src/build.js; } | xargs env",
"build": "yarn build:bin && yarn build:env",
"postinstall": "yarn build:from-env",
"postinstall": "npm run build:from-env",
"clean": "rm -rf xsnap-native/xsnap/build",
"lint": "run-s --continue-on-error lint:*",
"lint:js": "eslint 'src/**/*.js' 'test/**/*.js' api.js",
Expand Down

0 comments on commit 3f2b479

Please sign in to comment.