Merge pull request #8257 from Agoric/mfig-floating-seats

fix: properly exit floating `ZCFSeat` instances
Agoric · Aug 25, 2023 · 45667f5 · 45667f5
2 parents 22c3573 + bb2edbd
commit 45667f5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/packages/governance/src/electorateTools.js b/packages/governance/src/electorateTools.js
@@ -91,7 +91,10 @@ const getQuestion = (questionHandleP, questionStore) =>
  * @param {AddQuestion} addQuestion
  */
 const getPoserInvitation = (zcf, addQuestion) => {
-  const questionPoserHandler = () => Far(`questionPoser`, { addQuestion });
+  const questionPoserHandler = seat => {
+    seat.exit();
+    return Far(`questionPoser`, { addQuestion });
+  };
   return zcf.makeInvitation(questionPoserHandler, `questionPoser`);
 };
 

diff --git a/packages/inter-protocol/src/price/fluxAggregatorKit.js b/packages/inter-protocol/src/price/fluxAggregatorKit.js
@@ -255,6 +255,7 @@ export const prepareFluxAggregatorKit = async (
            * @param {ZCFSeat} seat
            */
           const offerHandler = async seat => {
+            seat.exit();
             const { oracle } = await facets.creator.initOracle(oracleId);
             const invitationMakers = Far('invitation makers', {
               /** @param {import('./roundsManager.js').PriceRound} result */
@@ -269,7 +270,6 @@ export const prepareFluxAggregatorKit = async (
                 );
               },
             });
-            seat.exit();
 
             return harden({
               invitationMakers,

diff --git a/packages/zoe/src/contracts/priceAggregator.js b/packages/zoe/src/contracts/priceAggregator.js
@@ -458,6 +458,7 @@ const start = async (zcf, privateArgs) => {
         seat,
         { notifier: oracleNotifier, scaleValueOut = 1 } = {},
       ) => {
+        seat.exit();
         const admin = await creatorFacet.initOracle(oracleKey);
         const invitationMakers = Far('invitation makers', {
           /** @param {ParsableNumber} price */
@@ -469,7 +470,6 @@ const start = async (zcf, privateArgs) => {
             }, 'PushPrice');
           },
         });
-        seat.exit();
 
         if (oracleNotifier) {
           pushFromOracle(oracleNotifier, scaleValueOut, r =>