Skip to content

Commit

Permalink
fix: use controllerConnectionId for ICQConnection (#9993)
Browse files Browse the repository at this point in the history
refs: #9815

## Description
Ensures we are passing `controllerConnectionId`, and not `hostConnectionId`, to `provideICQConnection`. _Was previously passing in CI since there's a 50/50 chance controllerConnectionId will equal hostConnectionId._

### Security Considerations
n/a

### Scaling Considerations
n/a

### Documentation Considerations
n/a

### Testing Considerations
Addresses a "flake" that's really a bug.

### Upgrade Considerations
n/a, unreleased code
  • Loading branch information
mergify[bot] authored Aug 29, 2024
2 parents 394a500 + fef71f4 commit 88fe8c9
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions packages/orchestration/src/exos/remote-chain-facade.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,7 @@ const prepareRemoteChainFacadeKit = (
// create a connection if it doesn't exist
const icqConnOrUndefinedV =
remoteChainInfo.icqEnabled && !this.state.icqConnection
? E(orchestration).provideICQConnection(
connectionInfo.counterparty.connection_id,
)
? E(orchestration).provideICQConnection(connectionInfo.id)
: undefined;

const makeAccountV = E(orchestration).makeAccount(
Expand Down Expand Up @@ -155,9 +153,7 @@ const prepareRemoteChainFacadeKit = (
// if none exists, make one and still send the query in the handler
if (!this.state.icqConnection) {
return watch(
E(orchestration).provideICQConnection(
connectionInfo.counterparty.connection_id,
),
E(orchestration).provideICQConnection(connectionInfo.id),
this.facets.makeICQConnectionQueryWatcher,
msgs,
);
Expand Down

0 comments on commit 88fe8c9

Please sign in to comment.