-
Notifications
You must be signed in to change notification settings - Fork 206
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(xsnap): Accommodate spaces in installation path (#10082)
## Description When installed on a Mac via npm in nvm, the path to the xsnap binary inevitably includes a space as in `Application Support`. The pattern `new URL(location).pathname` does not account for URL encoded spaces in the input URL, as will occur based on `import.meta.url`. This pivots xsnap to use `url.fileURLToPath` instead which does take these into account as well as Windows drive letters. ### Security Considerations None. ### Scaling Considerations None. ### Documentation Considerations None. ### Testing Considerations I created a git worktree named `agoric sdk` for the development of this branch. The xsnap tests failed under that directory name before this change, and worked afterward. ### Upgrade Considerations None.
- Loading branch information
Showing
4 changed files
with
24 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters