fixup! fix(vow): handle resolution loops in vows

add comment about reaching for vowV0
Agoric · Jun 22, 2024 · cb175ec · cb175ec
1 parent 14e6447
commit cb175ec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/packages/vow/src/watch.js b/packages/vow/src/watch.js
@@ -94,6 +94,7 @@ const preparePromiseWatcher = (zone, isRetryableReason, watchNextStep) =>
         const { watcher, watcherArgs, resolver, seenPayloads } = this.state;
         const payload = getVowPayload(value);
         if (payload) {
+          // TODO: rely on endowed helper to get storable cap from payload
           if (seenPayloads?.has(payload.vowV0)) {
             return this.self.onRejected(Error('Vow resolution cycle detected'));
           }

diff --git a/packages/vow/src/when.js b/packages/vow/src/when.js
@@ -30,6 +30,8 @@ export const makeWhen = (
     let priorRetryValue;
     const seenPayloads = new WeakSet();
     while (payload) {
+      // TODO: rely on endowed helpers for getting storable cap and performing
+      // shorten "next step"
       const { vowV0 } = payload;
       if (seenPayloads.has(vowV0)) {
         throw Error('Vow resolution cycle detected');