Skip to content

Commit

Permalink
fixup! feat(orchestration): service.js returns unwrapped vows
Browse files Browse the repository at this point in the history
  • Loading branch information
0xpatrickdev committed Jun 18, 2024
1 parent 45f2042 commit d106f82
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/orchestration/src/service.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const prepareOrchestrationKit = (
{
requestICAChannelWatcher: M.interface('RequestICAChannelWatcher', {
onFulfilled: M.call(M.remotable('Port'))
.optional({ remoteConnAddr: M.string() })
.optional({ chainId: M.string(), remoteConnAddr: M.string() })
.returns(NetworkShape.Vow$(NetworkShape.Connection)),
}),
requestICQChannelWatcher: M.interface('RequestICQChannelWatcher', {
Expand All @@ -93,7 +93,7 @@ const prepareOrchestrationKit = (
.returns(M.remotable('ConnectionKit Holder facet')),
}),
public: M.interface('OrchestrationService', {
makeAccount: M.callWhen(M.string(), M.string()).returns(
makeAccount: M.callWhen(M.string(), M.string(), M.string()).returns(
M.remotable('ChainAccountKit'),
),
provideICQConnection: M.callWhen(M.string()).returns(
Expand Down
2 changes: 2 additions & 0 deletions packages/orchestration/test/service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,12 @@ test('makeAccount returns a ChainAccount', async t => {
bootstrap: { orchestration },
} = await commonSetup(t);

const CHAIN_ID = 'cosmoshub-99';
const HOST_CONNECTION_ID = 'connection-0';
const CONTROLLER_CONNECTION_ID = 'connection-1';

const account = await E(orchestration).makeAccount(
CHAIN_ID,
HOST_CONNECTION_ID,
CONTROLLER_CONNECTION_ID,
);
Expand Down
4 changes: 1 addition & 3 deletions packages/orchestration/test/supports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ export const commonSetup = async t => {
sequence: false,
});

const { portAllocator, vowTools } = fakeNetworkEchoStuff(
rootZone.subZone('network'),
);
const { portAllocator } = fakeNetworkEchoStuff(rootZone.subZone('network'));

const { makeOrchestrationKit } = prepareOrchestrationTools(
rootZone.subZone('orchestration'),
Expand Down

0 comments on commit d106f82

Please sign in to comment.