types: GuestInterface supports synchronous returns

Agoric · Sep 10, 2024 · e77a98f · e77a98f
1 parent caf4f77
commit e77a98f
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 6 deletions.
diff --git a/packages/async-flow/src/types.d.ts b/packages/async-flow/src/types.d.ts
@@ -68,9 +68,11 @@ export type GuestInterface<T> = {
     ? (...args: Parameters<T[K]>) => Promise<R>
     : T[K] extends HostAsyncFuncWrapper
       ? GuestOf<T[K]>
-      : T[K] extends object
-        ? GuestInterface<T[K]>
-        : T[K];
+      : T[K] extends (...args: any[]) => infer R
+        ? T[K]
+        : T[K] extends object
+          ? GuestInterface<T[K]>
+          : T[K];
 };
 
 /**

diff --git a/packages/async-flow/test/types.test-d.ts b/packages/async-flow/test/types.test-d.ts
@@ -1,7 +1,11 @@
 import { expectType } from 'tsd';
-import type { Zone } from '@agoric/base-zone';
 import type { Vow, VowTools } from '@agoric/vow';
-import type { HostOf, GuestOf } from '../src/types.js';
+import type {
+  HostOf,
+  GuestOf,
+  HostInterface,
+  GuestInterface,
+} from '../src/types.js';
 
 const vt: VowTools = null as any;
 
@@ -20,3 +24,48 @@ expectType<(p1: number, p2: number) => Vow<void>>(
   // @ts-expect-error incompatible return type
   null as unknown as HostOf<typeof sumPromise>,
 );
+
+// Test HostInterface and GuestInterface with an exoClass object
+type ExoAPIBase = {
+  getValue: () => number;
+  setValue: (value: number) => void;
+  getCopyData: () => Record<string, number>[];
+};
+type ExoGuestAPI = ExoAPIBase & {
+  getValueAsync: () => Promise<number>;
+};
+
+type ExoHostAPI = ExoAPIBase & {
+  getValueAsync: () => Vow<number>;
+};
+
+expectType<
+  ExoAPIBase & {
+    getValueAsync: () => Vow<number>;
+  }
+>(null as unknown as HostInterface<ExoGuestAPI>);
+expectType<
+  ExoAPIBase & {
+    getValueAsync: () => Promise<number>;
+  }
+>(null as unknown as GuestInterface<ExoHostAPI>);
+
+// Test HostInterface and GuestInterface with classKit (nested) objects
+expectType<{
+  facet: ExoAPIBase & {
+    getValueAsync: () => Vow<number>;
+  };
+}>(
+  null as unknown as HostInterface<{
+    facet: ExoGuestAPI;
+  }>,
+);
+expectType<{
+  facet: ExoAPIBase & {
+    getValueAsync: () => Promise<number>;
+  };
+}>(
+  null as unknown as GuestInterface<{
+    facet: ExoHostAPI;
+  }>,
+);
diff --git a/packages/orchestration/src/examples/staking-combinations.flows.js b/packages/orchestration/src/examples/staking-combinations.flows.js
@@ -72,7 +72,6 @@ export const depositAndDelegate = async (
   const { give } = seat.getProposal();
   await zoeTools.localTransfer(seat, contractState.localAccount, give);
 
-  // @ts-expect-error Type 'GuestInterface<() => HostInterface<ChainAddress>>' has no call signatures.
   const address = account.getAddress();
   try {
     await contractState.localAccount.transfer(give.Stake, address);