smartWallet exits offers (e.g. bids) on zoe upgrade

[dckc]

Describe the bug

from the #8245 investigation with @warner:

when v9-zoe is upgraded, the wallet's executeOffer() code will observe the E(seatRef).numWantsSatisfied() promise get rejected/disconnected, which will reject the tryBody() promise, which will trigger the payment-recovery sequence and an E(seatRef).tryExit(), even though zoe's objects are still valid. Consequence: the offer is abandoned and refunded when that wasn't really necessary.

Design / Plan

• capture the bug in a test
• diagnose
• fix on master, with durability
  • fix on 8445 add promiseWatcher to smartWallet #8488 branch
• port fix to release branch (Rebase smartWallet (#8488) to release-mainnet1B branch #8609)

To Reproduce

Steps to reproduce the behavior:

1. place a bid
2. upgrade zoe
3. bid unexpectedly exits

Expected behavior

Long-lived offers should survive upgrade of zoe.

Platform Environment

mainnet1B

[dckc]

Since #8293 was complicated by related work in progress, I got started on this on Friday, capturing the bug in a test:

2023-12-01 17:52 8eb9cce WIP: test.failing('offer lasts across zoe upgrade',

I added a checklist to the description:

• capture the bug in a test
• diagnose
• fix on master, with durability
  • fix on 8445 add promiseWatcher to smartWallet #8488 branch
• port fix to release branch by way of (dev-upgrade-wallet-factory-2) branch introduced in Wallet factory upgrade 2 branch #8593

[dckc]

I think recent work by @Chris-Hibbert addresses this.

[Chris-Hibbert]

#8445 fixes the issue. It's not yet on the release branch.

[aj-agoric]

Moving to done as @Chris-Hibbert mentioned this was in the release branch and sufficiently tested.