drop node-fetch #10059
Merged
drop node-fetch #10059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
ad67dbe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://238f5468.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-drop-node-fetch.agoric-sdk.pages.dev |
turadg
force-pushed
the
ta/drop-node-fetch
branch
2 times, most recently
from
db1d974
to
0988e5b
Compare
turadg
force-pushed
the
ta/drop-node-fetch
branch
from
0988e5b
to
3debfa0
Compare
michaelfig
approved these changes
Sep 16, 2024
Node 18 provides it globally
using the Node 18 native one instead
turadg
force-pushed
the
ta/drop-node-fetch
branch
from
3debfa0
to
ad67dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evergreen
Description
fetchis now global in Node 18. Stop usingnode-fetchThis leaves the patch because some packages still transitively import it.
Security Considerations
fewer deps
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
Had to update a test that was checking the particular error message string
Upgrade Considerations
none