-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump typescript-eslint to 8.6.0 #10120
Draft
turadg
wants to merge
1
commit into
master
Choose a base branch
from
ta/typescript-eslint-8.6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
commented
Sep 19, 2024
@@ -62,8 +62,7 @@ module.exports = { | |||
root: true, | |||
parser: '@typescript-eslint/parser', | |||
parserOptions: { | |||
// Works for us! | |||
EXPERIMENTAL_useProjectService: true, | |||
projectService: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer experimental
Deploying agoric-sdk with Cloudflare Pages
|
OOMing locally:
|
mergify bot
added a commit
that referenced
this pull request
Sep 20, 2024
incidental ## Description Cleans up the README per #10121 (comment) I thought that was too light a PR so it also bumps typescript-eslint (not quite latest because that OOMs: #10120) Then I remember there are a couple filenames to normalize in examples this does that too. ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations Improved ### Testing Considerations CI ### Upgrade Considerations not deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evergreen
Description
I hoped to stop these messages,
But they're working on it:
https://github.com/typescript-eslint/typescript-eslint/issues/9653
(pinned to top of the issue list)Meanwhile we might as well get these improvements:
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
yarn lint
at root passes locallyyarn lint
in packages/orchestration (this is OOMing for me atm)Upgrade Considerations
n/a