Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify and finish unbond example #10121

Merged
merged 1 commit into from
Sep 20, 2024
Merged

simplify and finish unbond example #10121

merged 1 commit into from
Sep 20, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Sep 19, 2024

closes: #9782

Description

#9782 was to finish the example of "unbond and liquidate". We've punted Liquid Staking,

So to get a complete working example this does a transfer after unbonding.

Security Considerations

Not being deployed

Scaling Considerations

Not being deployed

Documentation Considerations

May become part of documentation, up to DevRel

Testing Considerations

CI

Upgrade Considerations

Not being deployed

Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58e38a2
Status:🚫  Build failed.

View logs

// TODO https://github.com/Agoric/agoric-sdk/issues/10017
// await strideAccount.liquidStake(tiaAmt);
console.log(osmoAccount, strideAccount);
const balance = await osmoAccount.getBalance('OSMO');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSMO works, and it doesn't need to be uosmo? Maybe grab stakingTokens[0] from chainInfo?

Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L20 // In a real world scenario, accounts would be re-used across invocations of the handler

Since #9796 is closed, and this PR will close 9782, can I request this is written as a continuing invitation? This would allow us to test in multichain-testing and improve the fidelity of our example contracts

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Sep 19, 2024
@0xpatrickdev
Copy link
Member

L20 // In a real world scenario, accounts would be re-used across invocations of the handler

Since #9796 is closed, and this PR will close 9782, can I request this is written as a continuing invitation? This would allow us to test in multichain-testing and improve the fidelity of our example contracts

Settled on a comment that points the reader to staking-combinations for an example of what I was asking for

@turadg
Copy link
Member Author

turadg commented Sep 20, 2024

@mergify requeue

Copy link
Contributor

mergify bot commented Sep 20, 2024

requeue

☑️ This pull request is already queued

@mergify mergify bot merged commit f29ecb3 into master Sep 20, 2024
79 of 80 checks passed
@mergify mergify bot deleted the 9782-unbond-example branch September 20, 2024 16:40
@dckc
Copy link
Member

dckc commented Sep 20, 2024

oh crud... I'm too slow to note the examples README should be updated:

## In Progress
The following contracts are a work in progress as they contain bindings that need to be promptly updated.
- **stakeIca.contract.js**: Interchain account creation for remote staking
- **unbond.contract.js**: Cross-chain unbonding and liquid staking

mergify bot added a commit that referenced this pull request Sep 20, 2024
incidental

## Description
Cleans up the README per #10121 (comment)

I thought that was too light a PR so it also bumps typescript-eslint (not quite latest because that OOMs: #10120)

Then I remember there are a couple filenames to normalize in examples this does that too.

### Security Considerations
n/a
### Scaling Considerations
n/a

### Documentation Considerations
Improved

### Testing Considerations
CI

### Upgrade Considerations
not deployed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unbondExample.contract.js is incomplete
3 participants