use readPublished for types in agoric-cli #10450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
c890f53
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fab14af4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-cli-readpublished.agoric-sdk.pages.dev |
turadg
commented
Nov 11, 2024
| @@ -98,13 +98,13 @@ export const makeGovCommand = (_logger, io = {}) => { | |||
| optUtils, | |||
| ) { | |||
| const utils = await (optUtils || makeVstorageKit({ fetch }, networkConfig)); | |||
| const { agoricNames, readLatestHead } = utils; | |||
| const { agoricNames, readPublished } = utils; | |||
There was a problem hiding this comment.
should we just pass the utils object instead of de- and re-structuring?
There was a problem hiding this comment.
No strong feelings, as long as the callees are clear about the least authority they need (using Pick<...> perhaps).
My vague memory is that I tried out several different ways to organize this stuff and either didn't find anything that I particularly liked or at least didn't go back to make things uniform.
There was a problem hiding this comment.
This way is done so I'll leave any other iterations to a future refactoring.
dckc
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up
Description
Pulled out of #10422 while debugging an intermittent Docker integration failure.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
none