fix(ertp): remove unneeded ertp type imports #10467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
fe06d31
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1490a6a.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-remove-unneeded-ertp-t.agoric-sdk.pages.dev |
erights
commented
Nov 13, 2024
| * Importing Baggage from `@agoric/ertp` is deprecated. Import Baggage from | ||
| * `@agoric/vat-data` instead | ||
| * | ||
| * @import {Baggage} from '@agoric/vat-data' |
There was a problem hiding this comment.
The only questionable one. See the discussion under "Upgrade Considerations" in the PR comment.
turadg
reviewed
Nov 13, 2024
Distraction. Makes it a bit harder to find the type imports that are actually used. Also, makes it a bit harder to search for "who meaningfully imports this type?". Same rationale for avoiding unused imports and other dead notation in general, though clearly of weaker magnitude for type imports. |
Chris-Hibbert
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #XXXX
Description
For some reason, vscode does successfully highlight unused jsdoc type imports
but
yarn lintdoes notThis PR started as a drive-by extracted from #10456 , where I noticed that ERTP in particular had some of these. Since #10456 experiments with a variation on ERTP, simplifying it first in harmless ways helps a bit.
Security Considerations
fewer distractions helps
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
none
Upgrade Considerations
In the agoric-sdk repo there are no remaining type imports of the legacy type reexport of
Baggagefrom ertp. But if there are such imports in other repos, they will need to be fixed. But this is a static-only issue, not a runtime issue, so it's fine for those repos to be fixed only once they depend on the new@agoric/ertpwithout that legacy reexport.