-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vault): econ metrics notifiers #5260
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
9cedbdc
chore(vault): type VaultUIState -> VaultTitleState
turadg 5334672
chore(zoe): type setupZCFTest
turadg af797d9
chore(vault): disambiguate VaultManager type (facet naming confusion)
turadg b4a5fcf
feat(vault): vaultDirector econ notifier
turadg 696b651
feat(vault): vaultManager econNotifier
turadg 8fc22d7
feat(vault): number of vaults per manager in EconState
turadg 4a0d2d6
style: fix 'object' type casing
turadg a6f5d8b
fixup! chore(vault): type VaultUIState -> VaultTitleState
turadg ae03243
'econ' -> 'metrics' (will squash)
turadg d0c7612
fixup! chore(vault): disambiguate VaultManager type (facet naming con…
turadg c5bd54d
size -> count
turadg e4401c1
undo name change in test
turadg 424776f
lint
turadg d9c0607
handleFooOffer style per https://github.com/Agoric/agoric-sdk/pull/5179
turadg 024c205
chore(zoe): more typing offerTo and Invitation
turadg 0cb7b4b
plan
turadg b13aba1
factored penalties into liquidation contracts
turadg 58d8555
rm obsolete partitionProceeds
turadg 276c94c
lint and comments
turadg c44cd1e
named parameters for makeGovernedTerms()
turadg 6a3349e
wire reservePublicFacet into vaultFactory terms
turadg 86dea15
rm obsolete penaltyPoolSeat
turadg db7194b
fixup! wire reservePublicFacet into vaultFactory terms
turadg db9e406
fixup! rm obsolete penaltyPoolSeat
turadg 4c92859
consume reserve instance instead of facet
turadg fff80b0
typecheck liquidator,vaultFactory tests
turadg 9e30183
fix test typo tsc caught
turadg d8fba65
fix invitation param and typecheck that would have caught it
turadg 74460d2
update comment docs
turadg bbb4ea9
work around type resolution shortcomings
turadg 01c3fe6
better comments
turadg 96c9811
Merge branch 'master' into 5167-liq-penalty
turadg 443a932
Merge branch 'master' into 4649-expose-vaultFactor-econ-metrics
turadg 58f8d9d
fixup undo vaultFactoryCreator
turadg 3fe00a4
getMetrics
turadg 30a8eaf
use subscriptions
turadg 9dd27d9
revert rename getNotifier (no ambiguity anymore)
turadg 905e07c
fix lint my editor didn't show 🤷
turadg d1b2344
fixup! getMetrics
turadg 41fa373
update metrics after each liquidation
turadg d3bc2d9
Merge branch '5167-liq-penalty' into 4649-expose-vaultFactor-econ-met…
turadg fc54589
fix test for manager notifiers
turadg cf8030d
Merge branch 'master' into 4649-expose-vaultFactor-econ-metrics
turadg 38219e8
Merge branch 'master' into 4649-expose-vaultFactor-econ-metrics
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a general term for the state snapshot from a notifier. We could remove "UI" from that with "vaultSnapshot"? but "vaultState" isn't terrible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came up above and proposed
Notification
. I could see that being used for the wrapping object (withvalue
andupdateCount
) but that's so generic as to not need a name.