fix(wallet/ui): style connection component better #5984
Conversation
| const pathStyle = { fill: '#bb2d40' }; | ||
|
|
||
| return ( | ||
| <svg |
There was a problem hiding this comment.
For some reason loading a static resource was messing with the ability of the bridge to connect to localstorage, so just include this in the bundle
There was a problem hiding this comment.
I recall there are some bad ways to use SVG in React but I don't remember whether this is one of them :) Either way, seems fine for now. Optimize after correctness.
There was a problem hiding this comment.
Fixed in d823ccd, but I'll leave this in anyway because it's small enough and will look better not loading in separately.
| const pathStyle = { fill: '#bb2d40' }; | ||
|
|
||
| return ( | ||
| <svg |
There was a problem hiding this comment.
I recall there are some bad ways to use SVG in React but I don't remember whether this is one of them :) Either way, seems fine for now. Optimize after correctness.
packages/wallet/ui/src/bridge.jsx
Outdated
| ); | ||
| const Bridge = () => { | ||
| return ( | ||
| <button className="button" onClick={signalBridge}> |
There was a problem hiding this comment.
button.button is a funny target. consider an id since there will be exactly one in the DOM:
| <button className="button" onClick={signalBridge}> | |
| <button id="signalWallet" onClick={signalBridge}> |
There was a problem hiding this comment.
Changed to signal-wallet-button
There was a problem hiding this comment.
That might have been me, aiming for type=button, which suppresses form submission, iirc
samsiegart
added
automerge:squash
refs: Agoric/dapp-treasury#137