refactor(vaultFactory!): vaultFactory use zcf.atomicRearrange #7901
Conversation
Chris-Hibbert
force-pushed
the
6678-intrinsicAtomicTransfer
branch
from
b8f88d7
to
14ac202
Compare
Chris-Hibbert
force-pushed
the
6678-intrinsicAtomicTransfer
branch
from
a7a4fed
to
a16493d
Compare
Chris-Hibbert
force-pushed
the
6678-intrinsicAtomicTransfer
branch
from
a16493d
to
b9c3ff2
Compare
Chris-Hibbert
force-pushed
the
6678-atomicVaultFactory
branch
from
69682f6
to
eb9a3cc
Compare
There was a problem hiding this comment.
eb9a3cc LGTM.
This PR has some other commits which should be omitted. It's also not ready for merge until we have the Zoe upgrade test fleshed out so I'm requesting changes that it:
- be based off master (or combined into another PR that is)
- be put up for review after Zoe Upgrade is fully tested in CI
Chris-Hibbert
force-pushed
the
6678-atomicVaultFactory
branch
from
eb9a3cc
to
a2a92fb
Compare
Deploying agoric-sdk with
|
| Latest commit: |
ac5b128
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://84af5f06.agoric-sdk.pages.dev |
| Branch Preview URL: | https://6678-atomicvaultfactory.agoric-sdk.pages.dev |
There was a problem hiding this comment.
Approving with same reservations as #7904 (review)
I'm surprised to see three PRs with the same change
Chris-Hibbert
force-pushed
the
6678-atomicVaultFactory
branch
from
a2a92fb
to
ac5b128
Compare
The plan is to upgrade vaults and auctions in the priceFeed coreEval, which is coming soon. I didn't send the PSM change to you (but appreciate the approval) because I want to discuss when they should be upgraded beforehand.
It enables merging them separately as we know which ones will be upgraded in a particular release. |
refs: #6678
refs: #7900
Description
update VaultFactory to use zcf.atomicRearrange.
This change must not be pushed to the chain before #7900.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
None
Release considerations
This requires a change to Zoe (#7900). Since VaultFactory gets upgraded separately from Zoe, this is staged as a separate PR. Once #7900 is on chain, this update can be made, even if it's in the same release cycle, as long as Zoe is upgraded first. This change is independent of changes to other contracts.