fix(vats): update error message test #7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-update-error-message-test
branch
from
0b7ec35
to
37bae13
Compare
michaelfig
approved these changes
Jun 25, 2023
There was a problem hiding this comment.
Given the testing, and @gibson042's precedent, this change makes sense to me.
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
fix(vats): update error message test
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
fix(vats): update error message test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the version slippage error detected at https://github.com/Agoric/agoric-sdk/actions/runs/5349653284/jobs/9701289352?pr=7937#step:5:3006 , we follow @gibson042 's precedent at #7932 .
We test it under CI by having this PR's CI run as normal, and have #7937 restaged on this PR, so its CI will detect whether this PR's change fixes that problem.