Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript 5.2 #8252

Merged
merged 4 commits into from
Sep 1, 2023
Merged

typescript 5.2 #8252

merged 4 commits into from
Sep 1, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Aug 24, 2023

Description

https://devblogs.microsoft.com/typescript/announcing-typescript-5-2/

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

not necessary

Testing Considerations

CI sufficient

Upgrade Considerations

No runtime changes

@turadg turadg requested review from dckc and iomekam August 24, 2023 20:45
dckc
dckc approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer to the release notes

packages/zoe/src/contracts/loan/types.js
@@ -134,13 +134,6 @@
* @returns {Promise<Invitation>} addCollateralInvitation
*/

/**
* @callback Liquidate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never was a fan of @callback

@turadg
Copy link
Member Author

turadg commented Aug 25, 2023

Gonna hold off on this until typescript-eslint/typescript-eslint#7155

Without it,

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.2.0

YOUR TYPESCRIPT VERSION: 5.2.2

Please only submit bug reports when using the officially supported version.

=============

@turadg turadg added automerge:rebase Automatically rebase updates, then merge bypass:integration Prevent integration tests from running on PR labels Sep 1, 2023
@mergify mergify bot merged commit 3d3660b into master Sep 1, 2023
88 checks passed
@mergify mergify bot deleted the typescript-5.2 branch September 1, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iomekam iomekam iomekam approved these changes

@dckc dckc dckc approved these changes

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge bypass:integration Prevent integration tests from running on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turadg @dckc @iomekam