test: show that smartWallet fails if zoe upgrades. due to #8445 #8477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Oct 26, 2023
| // /////// Upgrading //////////////////////////////// | ||
| const zoeUpgradeSpec = { | ||
| package: 'builders', | ||
| packageScriptName: 'build:null-upgrade-zoe-proposal', |
There was a problem hiding this comment.
Oops, I'll wrap this one up, I got distracted with other work!
There was a problem hiding this comment.
@Chris-Hibbert, if this goes in first, I'll refactor it in #8449
Chris-Hibbert
force-pushed
the
8445-demonstrate-failure
branch
from
bc3a933
to
4c8a834
Compare
Chris-Hibbert
added
the
automerge:rebase
Chris-Hibbert
force-pushed
the
8445-demonstrate-failure
branch
from
4c8a834
to
91b4e31
Compare
Chris-Hibbert
force-pushed
the
8445-demonstrate-failure
branch
from
91b4e31
to
f4894c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8445
Description
Add a .failing test to demonstrate the issue described in #8445. The real coup will be fixing the test.
Security Considerations
See upgrade
Scaling Considerations
Repairing this will require us to enumerate wallets and reattach promises. If we wait until later, there will be more wallets.
Documentation Considerations
None
Testing Considerations
This is just a test.
Upgrade Considerations
See #8445.