xsnap without git

[warner]

Use presence/absence of submodule directories and their .git metadata to distinguish between an agoric-sdk clone and an unpacked NPM tarball. Use git submodule update --init in the first case, and leave the sources alone in the last case.

Still needs real tests, but manual testing passes.

refs #8536

[dckc]

Manual testing how?

I'm losing.

I checked out 36e5cad and did yarn pack in packages/xsnap. Then:

case A: ... fatal: not a git repository

$ pushd /tmp/
/tmp ~/projects/dapp-agoric-basics/contract
danbook:tmp connolly$ mkdir x
danbook:tmp connolly$ cd x
danbook:x connolly$ yarn add /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz
yarn add v1.22.19
info No lockfile found.
[1/4] 🔍  Resolving packages...
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/promise-kit > [email protected]: Please upgrade to ses@^1.1.0. Version 0.18.8 breaks in the presence of the new JavaScript iterator helpers.
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/init > @endo/promise-kit > [email protected]: Please upgrade to ses@^1.1.0. Version 0.18.8 breaks in the presence of the new JavaScript iterator helpers.
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/stream > [email protected]: Please upgrade to ses@^1.1.0. Version 0.18.8 breaks in the presence of the new JavaScript iterator helpers.
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/stream-node > [email protected]: Please upgrade to ses@^1.1.0. Version 0.18.8 breaks in the presence of the new JavaScript iterator helpers.
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/stream-node > @endo/stream > [email protected]: Please upgrade to ses@^1.1.0. Version 0.18.8 breaks in the presence of the new JavaScript iterator helpers.
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/netstring > [email protected]: Please upgrade to ses@^1.1.0. Version 0.18.8 breaks in the presence of the new JavaScript iterator helpers.
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/init > @endo/lockdown > [email protected]: Please upgrade to ses@^1.1.0. Version 0.18.8 breaks in the presence of the new JavaScript iterator helpers.
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/bundle-source > @endo/compartment-mapper > [email protected]: Please upgrade to ses@^1.1.0. Version 0.18.8 breaks in the presence of the new JavaScript iterator helpers.
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/bundle-source > @endo/compartment-mapper > @endo/static-module-record > [email protected]: Please upgrade to ses@^1.1.0. Version 0.18.8 breaks in the presence of the new JavaScript iterator helpers.
warning /Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/bundle-source > @rollup/plugin-commonjs > magic-string > [email protected]: Please use @jridgewell/sourcemap-codec instead
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "/Users/connolly/projects/ag-xsnap-no-git/packages/xsnap/agoric-xsnap-v0.14.3-u12.0.tgz > @endo/bundle-source > jessie.js > @endo/far > @endo/pass-style > @fast-check/[email protected]" has unmet peer dependency "ava@^4 || ^5 || ^6".
[4/4] 🔨  Building fresh packages...
error /private/tmp/x/node_modules/@agoric/xsnap: Command failed.
Exit code: 1
Command: yarn build
Arguments: 
Directory: /private/tmp/x/node_modules/@agoric/xsnap
Output:
yarn run v1.22.19
$ node src/build.js
moddable case A: no submodule/ directory : do init
fatal: not a git repository (or any of the parent directories): .git
Error: git exited with code 128
    at ChildProcess.<anonymous> (file:///private/tmp/x/node_modules/@agoric/xsnap/src/build.js:107:18)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess._handle.onexit (node:internal/child_process:292:12)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

[dckc]

I managed to yarn pack it in such a way that it works in a new /tmp/x project.

But when I try to install it in dapp-agoric-basics, I can't seem to avoid the git clone. There are 2 @agoric/xsnap packages being built.