chore(release): publish agoric-upgrade-13 #8633

mhofman · 2023-12-07T02:10:38Z

Packages that have NEWS.md updates

--- a/golang/cosmos/CHANGELOG.md
+++ b/golang/cosmos/CHANGELOG.md
@@ -3,6 +3,30 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.35.0-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Features
+
+* **cosmos:** un-wire x/crisis ([#8582](https://github.com/Agoric/agoric-sdk/issues/8582)) ([19404a3](https://github.com/Agoric/agoric-sdk/commit/19404a3c5cd10d9c454f190b60cbf0aa715f605c))
+* **x/swingset:** auto-provision smart wallet ([5073800](https://github.com/Agoric/agoric-sdk/commit/5073800f87c92a194a21c9cc59ad1bb570a39b95))
+* **x/swingset:** refuse smart wallet messages if not provisioned ([50a5a55](https://github.com/Agoric/agoric-sdk/commit/50a5a557956562fc05b8c2defd99a0102a35153f))
+* pick up return-grants from latest cosmos-sdk ([975533e](https://github.com/Agoric/agoric-sdk/commit/975533e088f96c80cf8d6f6b7c5f45665e3495ba))
+* update ibc-go to v4, adapt packages and API ([6672e5c](https://github.com/Agoric/agoric-sdk/commit/6672e5cb780c8baa530ac59bff27d793e1ff8f50))
+
+
+### Bug Fixes
+
+* handle hang-on-halt behavior from agoric-labs/cosmos-sdk[#305](https://github.com/Agoric/agoric-sdk/issues/305) ([7ae9a70](https://github.com/Agoric/agoric-sdk/commit/7ae9a705478727d1d7ace7c665861cfee14b5f28))
+* update dependencies to fix tests ([9d750dd](https://github.com/Agoric/agoric-sdk/commit/9d750dd39993d380a5e889ea7faa4bb78c3257aa))
+
+
+### Reverts
+
+* Revert "fix: handle hang-on-halt behavior from agoric-labs/cosmos-sdk#305" ([3a37f5e](https://github.com/Agoric/agoric-sdk/commit/3a37f5e472405d1d3bee2075b47ecd3632ba4073)), closes [agoric-labs/cosmos-sdk#305](https://github.com/agoric-labs/cosmos-sdk/issues/305) [agoric-labs/cosmos-sdk#305](https://github.com/agoric-labs/cosmos-sdk/issues/305)
+
+
+
 ## [0.35.0-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 
--- a/packages/SwingSet/CHANGELOG.md
+++ b/packages/SwingSet/CHANGELOG.md
@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.32.3-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Bug Fixes
+
+* handle Node 18 breaking change ([#8600](https://github.com/Agoric/agoric-sdk/issues/8600)) ([2c64440](https://github.com/Agoric/agoric-sdk/commit/2c64440d5b5957076ad9ac7b9243de3b600c859f))
+
+
+
 ### [0.32.3-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 
--- a/packages/agoric-cli/CHANGELOG.md
+++ b/packages/agoric-cli/CHANGELOG.md
@@ -3,6 +3,32 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.22.0-u13.0](https://github.com/Agoric/agoric-sdk/compare/[email protected]@0.22.0-u13.0) (2023-12-07)
+
+
+### ⚠ BREAKING CHANGES
+
+* restrict exports from 'agoric' package
+
+### Features
+
+* **cosmos:** un-wire x/crisis ([#8582](https://github.com/Agoric/agoric-sdk/issues/8582)) ([19404a3](https://github.com/Agoric/agoric-sdk/commit/19404a3c5cd10d9c454f190b60cbf0aa715f605c))
+
+
+### Bug Fixes
+
+* **agops:** fix continuing id lookup in oracle setPrice ([0ac9697](https://github.com/Agoric/agoric-sdk/commit/0ac969746c7337d45287fd040b636d27d296a062))
+* **agoric:** print errors while following ([deab7e4](https://github.com/Agoric/agoric-sdk/commit/deab7e4065fe5dd6cc1a3c5bf8c0db861cb7856b))
+* **casting:** dont crash on bad capdata ([3f01369](https://github.com/Agoric/agoric-sdk/commit/3f0136994c0b4033c872f9593cabb19bab05f01c))
+* **cli:** handle not found error in vstorage requests ([8111c43](https://github.com/Agoric/agoric-sdk/commit/8111c4344bcaa6e06085020813e2431cba9d1632))
+
+
+### Miscellaneous Chores
+
+* restrict exports from 'agoric' package ([63c1abb](https://github.com/Agoric/agoric-sdk/commit/63c1abbfcb0710bdd0a22382eb4a683216a6c453))
+
+
+
 ### [0.21.2-u12.0](https://github.com/Agoric/agoric-sdk/compare/[email protected]@0.21.2-u12.0) (2023-11-10)
 
 **Note:** Version bump only for package agoric
--- a/packages/casting/CHANGELOG.md
+++ b/packages/casting/CHANGELOG.md
@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.4.3-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Bug Fixes
+
+* **casting:** dont crash on bad capdata ([3f01369](https://github.com/Agoric/agoric-sdk/commit/3f0136994c0b4033c872f9593cabb19bab05f01c))
+* **casting:** properly follow an unpopulated state entry ([48296f7](https://github.com/Agoric/agoric-sdk/commit/48296f78f783e8e5ae1e5fbe92ae10e5e7880837))
+
+
+
 ### [0.4.3-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 **Note:** Version bump only for package @agoric/casting
--- a/packages/cosmic-swingset/CHANGELOG.md
+++ b/packages/cosmic-swingset/CHANGELOG.md
@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.42.0-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Features
+
+* add exporter.getHostKV() API ([16435d2](https://github.com/Agoric/agoric-sdk/commit/16435d20e9ede86916a54c7bae54ecfc59e4c950)), closes [#8523](https://github.com/Agoric/agoric-sdk/issues/8523)
+
+
+### Bug Fixes
+
+* export state-sync snapshot without a DB write-lock ([2d388c2](https://github.com/Agoric/agoric-sdk/commit/2d388c2d51425b9d98b79d54ea6a2de96da67042)), closes [#8523](https://github.com/Agoric/agoric-sdk/issues/8523)
+
+
+
 ## [0.42.0-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 
--- a/packages/inter-protocol/CHANGELOG.md
+++ b/packages/inter-protocol/CHANGELOG.md
@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.16.2-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Bug Fixes
+
+* **inter-protocol:** brands in CLI need not start with A-Z ([#8258](https://github.com/Agoric/agoric-sdk/issues/8258)) ([fd9a44d](https://github.com/Agoric/agoric-sdk/commit/fd9a44db84e2cb9c9c78f850be7dbb8911650d54))
+
+
+
 ### [0.16.2-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 **Note:** Version bump only for package @agoric/inter-protocol
--- a/packages/solo/CHANGELOG.md
+++ b/packages/solo/CHANGELOG.md
@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.10.4-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Bug Fixes
+
+* **solo:** properly expose `/wallet/bridge.html` ([#8533](https://github.com/Agoric/agoric-sdk/issues/8533)) ([0095b0d](https://github.com/Agoric/agoric-sdk/commit/0095b0d8ef4cfd42e17b64f391c30eac8a5f018a))
+
+
+
 ### [0.10.4-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 
--- a/packages/swing-store/CHANGELOG.md
+++ b/packages/swing-store/CHANGELOG.md
@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.9.2-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Features
+
+* add exporter.getHostKV() API ([16435d2](https://github.com/Agoric/agoric-sdk/commit/16435d20e9ede86916a54c7bae54ecfc59e4c950)), closes [#8523](https://github.com/Agoric/agoric-sdk/issues/8523)
+
+
+
 ### [0.9.2-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)

agoric-upgrade-13

it's only for installing the bin and importing that bin module

until Agoric/testnet-load-generator#112

refactor clientSupport to not depend on agoric-cli package

* fix(inter-protocol): brands in CLI need not start with A-Z * test(inter-protocol): clientSupport for initial non-uppercase * fixup! fix(inter-protocol): brands in CLI need not start with A-Z --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

The backport referenced above has the agd process hang around after halting. Wrote a wrapper utility which scans stderr for the halt application message, interrupts the process, then propagates its error signal. Conventional shell scripting is not up to the challenge of expressing this behavior.

…#305" This reverts commit efcc3b0. We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).

feat: update ibc-go to v4, adapt packages and API

…t-found fix(cli): handle not found error in vstorage requests

needs instance based on --pair

fix(casting): dont crash on bad capdata

fix(agops): fix continuing id lookup in oracle setPrice

Exporting a state-sync snapshot is a read-only operation, and is designed to run "in the background", i.e. in parallel with normal mutating operations. It accomplishes this by opening a read-only transaction right away, effectively capturing a snapshot of the SQLite database state, to insulate the export process from ongoing writes by the execution host. The cosmic-swingset exporter starts with a query of `host.height`, to confirm that the database has not already advanced to a new block before this snapshot/read-transaction can be taken. Previously, this query worked by using `openSwingStore`, and then calling `hostStorage.hostKVStore.get('host.height')`. This had two problems: * TOCTTOU: the `hostKVStore.get` used a different DB connection (and different txn) than the exporter, so it might return a different height, negating the accuracy of the consistency check * read-write txn: `openSwingStore` creates a read-*write* txn, even when merely opening the DB (because it might need to create the initial tables). This txn is closed right away, before `openSwingStore()` returns, so it did not present a threat to ongoing operations. But if the exporter was created while the ongoing execution side already had its own read-write txn open (e.g. while `controller.run()` was running), then it would fail, and `makeSwingStoreExporter` would fail with `SQLITE_BUSY` Instead, we take advantage of the new `swingStoreExporter.getHostKV()` API, and use *it* to fetch `host.height`. Unlike the normal swingstore, the swingstore-exporter refrains from creating read-write transactions entirely. So the cosmic-swingset export code can safely query the height without fear of getting the wrong value or failing because of an ongoing write transaction. We think this should fix the SQLITE_BUSY errors. refs #8523

…lock fix: export state-sync snapshot without a DB write-lock

feat: allow clawback vesting accounts to return grants

Auto-provision smart wallet

* feat(cosmos): un-wire x/crisis * fixup! feat(cosmos): un-wire x/crisis --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

mhofman · 2023-12-07T02:11:37Z

The release commit is be59032, rest comes from previous dev-upgrade-13 branch PRs.

toliaqat

Looks good overall.
Left couple of comments and wanted you to double if we need to update the following file?

packages/xsnap/package.json

https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/xsnap/package.json#L31

toliaqat · 2023-12-07T04:01:30Z

packages/deployment/upgrade-test/Readme.md

@@ -24,7 +14,7 @@ By default pre-releases use the lastest image tagged `dev` in our [container rep
 a specific build:

 ```shell
-DEST_IMAGE=docker pull ghcr.io/agoric/agoric-sdk:20230515033839-e56ae7
+DEST_IMAGE=ghcr.io/agoric/agoric-sdk:20230515033839-e56ae7


Do we need to change this tag?

It's just an example in the readme

toliaqat · 2023-12-07T04:04:07Z

golang/cosmos/app/app.go

-// upgrade12Handler performs standard upgrade actions plus custom actions for upgrade-12.
-func upgrade12Handler(app *GaiaApp, targetUpgrade string) func(sdk.Context, upgradetypes.Plan, module.VersionMap) (module.VersionMap, error) {
+// upgrade13Handler performs standard upgrade actions plus custom actions for upgrade-13.
+func upgrade13Handler(app *GaiaApp, targetUpgrade string) func(sdk.Context, upgradetypes.Plan, module.VersionMap) (module.VersionMap, error) {


If there is nothing specific in this function, should we rename it to just upgradeHandler?

That's how we've been managing upgrade handlers. This change is coming from #8588 which prepared the upgrade-13 branch

toliaqat · 2023-12-07T04:06:07Z

packages/deployment/upgrade-test/Makefile

@@ -43,4 +43,4 @@ run_test:
 shell:
 	docker exec -it `docker ps --latest --format json | jq -r .Names` bash

-.PHONY: local_sdk agoric-upgrade-7-2 agoric-upgrade-8 agoric-upgrade-8-1 agoric-upgrade-9 agoric-upgrade-10 agoric-upgrade-11 agoric-upgrade-12 build build_test run
+.PHONY: local_sdk agoric-upgrade-13 build build_test run


Why we not need to run all the upgrades like before?

Because those are now part of agoric-3-proposals. This was some cleanup done in #8588

toliaqat

@mhofman I am conditionally approving this PR. Please check if you need to update version numbers in the following file before merging this PR.

https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/xsnap/package.json

mhofman · 2023-12-07T12:34:13Z

@mhofman I am conditionally approving this PR. Please check if you need to update version numbers in the following file before merging this PR.

https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/xsnap/package.json

Oh I see what you mean. The xsnap-lockdown version didn't get bumped, and arguably it should to represent the fact the bundle on chain is now different. I'll see what I can do.

Reflect patch-package of transitive dependency

mhofman · 2023-12-07T15:07:32Z

@toliaqat I forced a version bump on xsnap-lockdown, triggering a bump on xsnap as well.
I also included the fix from #8527 (which is still pending review...) since the tag tool is currently broken

Overall diff since reviewed: be59032..5a6cdeb

PTAL

toliaqat · 2023-12-07T17:12:39Z

@mhofman thank you.

I think because of the broken tool, we missed u11wf.0 tag updates in the past as well.
Can you check if we need to update them for @agoric/assert and @agoric/access-token pacakges.
https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/agoric-cli/package.json#L37

And update version in eslint-config
https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/eslint-config/package.json#L3

mhofman · 2023-12-07T18:04:32Z

I think because of the broken tool, we missed u11wf.0 tag updates in the past as well.

To be clear, it's totally normal for packages that didn't experience any changes to not get their version bumped. In the case of xsnap-lockdown it actually was a problem because we patched ses resulting in a different content of the distributed bundle. I don't think it was your intent to point this specific issue out, but your review made me realize the problem, which I've addressed for that package specifically.

The other packages can stay without a version change.

toliaqat · 2023-12-07T18:07:04Z

🚀

mhofman and others added 30 commits December 1, 2023 17:13

docs(upgrade-test): revise readme

080f5d4

chore: rename next upgrade

6b984ef

chore: remove upgrade-12 and other actions

6426775

Merge pull request #8588 from Agoric/mhofman/8578-upgrade-13-name

5fe83be

agoric-upgrade-13

fix: handle Node 18 breaking change (#8600)

2c64440

refactor: OfferMaker takes agoricNames

a1a75a0

refactor(clientSupport): move makeParseAmount

7ae9ebc

refactor(clientSupport): inline parseAmount

ef0730f

chore!: restrict exports from 'agoric' package

63c1abb

it's only for installing the bin and importing that bin module

chore(deps): remove dep on 'agoric'

2de09de

build: export for loadgen

9b1b763

until Agoric/testnet-load-generator#112

Merge pull request #7824 from Agoric/ta/refactor-clientSupport

89add68

refactor clientSupport to not depend on agoric-cli package

feat: update ibc-go to v4, adapt packages and API

6672e5c

build: eliminate dependence on gaia/ag0

f113b2d

Revert "fix: handle hang-on-halt behavior from agoric-labs/cosmos-sdk…

3a37f5e

…#305" This reverts commit efcc3b0. We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).

fix: update dependencies to fix tests

9d750dd

chore: upgrade ibc-go to latest patch version

db4dc7b

docs: update changelog

057f9f0

fix(cli): handle not found error in vstorage requests

8111c43

Merge pull request #8409 from Agoric/8223-ibc-4

0b84aca

feat: update ibc-go to v4, adapt packages and API

chore(x/vstorage): add querier test

715141b

fix(solo): properly expose /wallet/bridge.html (#8533)

0095b0d

fix(casting): dont crash on bad capdata

3f01369

Merge pull request #8538 from Agoric/mhofman/8535-fix-cli-vstorage-no…

b9d5f83

…t-found fix(cli): handle not found error in vstorage requests

fix(agops): fix continuing id lookup in oracle setPrice

0ac9697

needs instance based on --pair

Merge pull request #8562 from Agoric/sam/casting-capdata-errors

a126c15

fix(casting): dont crash on bad capdata

chore(upgrade-test): various fixes

54127af

Merge pull request #8457 from Agoric/dc-setPrice-mcs

deb940f

fix(agops): fix continuing id lookup in oracle setPrice

mhofman and others added 12 commits December 6, 2023 20:07

feat(x/swingset): refuse smart wallet messages if not provisioned

50a5a55

chore(cosmos): always update swingset params on upgrade

2338ba2

feat: pick up return-grants from latest cosmos-sdk

975533e

Merge pull request #8619 from Agoric/warner/8523-export-without-write…

b4fff23

…lock fix: export state-sync snapshot without a DB write-lock

feat(x/swingset): auto-provision smart wallet

5073800

Merge pull request #8616 from Agoric/8570-return-grants

d78107c

feat: allow clawback vesting accounts to return grants

chore(upgrade-test): add test of auto-provision

e0a2f1d

Merge pull request #8602 from Agoric/mhofman/8558-auto-provision

c58021d

Auto-provision smart wallet

feat(cosmos): un-wire x/crisis (#8582)

19404a3

* feat(cosmos): un-wire x/crisis * fixup! feat(cosmos): un-wire x/crisis --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

chore(web-components): fix lint

457beb3

rebase/cherry-pick commits for upgrade 13 (#8623)

24acd13

mhofman requested a review from toliaqat December 7, 2023 02:10

mhofman added the force:integration Force integration tests to run on PR label Dec 7, 2023

toliaqat reviewed Dec 7, 2023

View reviewed changes

toliaqat approved these changes Dec 7, 2023

View reviewed changes

mhofman added 3 commits December 7, 2023 14:38

chore(xsnap-lockdown): Force version bump

ffa91c6

Reflect patch-package of transitive dependency

chore: fix release instructions and tools

4597fe3

mhofman force-pushed the prepare-release-20231207T020132 branch from be59032 to 5a6cdeb Compare December 7, 2023 14:58

mhofman requested a review from toliaqat December 7, 2023 15:07

toliaqat approved these changes Dec 7, 2023

View reviewed changes

mhofman merged commit b0c1f78 into release-mainnet1B Dec 7, 2023
60 checks passed

mhofman deleted the prepare-release-20231207T020132 branch December 7, 2023 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(release): publish agoric-upgrade-13 #8633

chore(release): publish agoric-upgrade-13 #8633

mhofman commented Dec 7, 2023

mhofman commented Dec 7, 2023

toliaqat left a comment

toliaqat Dec 7, 2023

mhofman Dec 7, 2023

toliaqat Dec 7, 2023

mhofman Dec 7, 2023

toliaqat Dec 7, 2023

mhofman Dec 7, 2023

toliaqat left a comment

mhofman commented Dec 7, 2023

mhofman commented Dec 7, 2023

toliaqat commented Dec 7, 2023

mhofman commented Dec 7, 2023

toliaqat commented Dec 7, 2023

chore(release): publish agoric-upgrade-13 #8633

chore(release): publish agoric-upgrade-13 #8633

Conversation

mhofman commented Dec 7, 2023

Packages that have NEWS.md updates

mhofman commented Dec 7, 2023

toliaqat left a comment

Choose a reason for hiding this comment

toliaqat Dec 7, 2023

Choose a reason for hiding this comment

mhofman Dec 7, 2023

Choose a reason for hiding this comment

toliaqat Dec 7, 2023

Choose a reason for hiding this comment

mhofman Dec 7, 2023

Choose a reason for hiding this comment

toliaqat Dec 7, 2023

Choose a reason for hiding this comment

mhofman Dec 7, 2023

Choose a reason for hiding this comment

toliaqat left a comment

Choose a reason for hiding this comment

mhofman commented Dec 7, 2023

mhofman commented Dec 7, 2023

toliaqat commented Dec 7, 2023

mhofman commented Dec 7, 2023

toliaqat commented Dec 7, 2023