Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WalletFactory survive upgrades and repair outstanding purses and offers #8773

Merged
merged 10 commits into from
Jan 20, 2024
Merged

WalletFactory survive upgrades and repair outstanding purses and offers #8773

merged 10 commits into from
Jan 20, 2024
+1,301 −430

Commits on Jan 19, 2024

  1. feat: smartWallet verstion 2 with watchedPromises 

    pulled offers.js and payments.js into smartWallet.js as they shared
plenty of state that needs to be durable in order to be callable from
the watchedPromise.

build an upgrade proposal; tested in
Agoric/agoric-3-proposals#34
    @turadg @mhofman
    turadg authored and mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    24527bb View commit details
    Browse the repository at this point in the history

  2. fix(smartWallet): handle upgrade disconnects from purse notifiers 

    observeNotifier() would handle upgrade disconnects if the notifiers
were durable. But in @agoric/ertp, they're ephemeral, so we open-code
the loop.

When the offerWatchers detect an upgrade, they reschedule the
watchers. We needed to ensure the wallet itself doesn't do its cleanup
in that case.

The test updates purse balance across upgrade
  - provision a smartWallet for an oracle operator
  - upgrade zoe; reproduce smartWallet bug
  - check for new invitation
    @dckc @mhofman
    dckc authored and mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    41287a6 View commit details
    Browse the repository at this point in the history

  3. feat: repairUnwatchedPurses 

    feat: include invitation purses in repairUnwatchedPurses
    @Chris-Hibbert @mhofman
    Chris-Hibbert authored and mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    be1b237 View commit details
    Browse the repository at this point in the history

  4. chore: ignore ts error for type of watchPromise

    @Chris-Hibbert @mhofman
    Chris-Hibbert authored and mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9ef5861 View commit details
    Browse the repository at this point in the history

  5. chore: move test-wallet-upgrade from boot back to vats

    @dckc @mhofman
    dckc authored and mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    d262617 View commit details
    Browse the repository at this point in the history

  6. chore: update imports in test-wallet-upgrade

    @dckc @mhofman
    dckc authored and mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ce2bf57 View commit details
    Browse the repository at this point in the history

  7. chore: punt other another wallet test file 

    covered better by a3p integration tests
    @dckc @mhofman
    dckc authored and mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    5d0194e View commit details
    Browse the repository at this point in the history

  8. chore: repair changed dropped from smartWallet

    @Chris-Hibbert @mhofman
    Chris-Hibbert authored and mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    03ef418 View commit details
    Browse the repository at this point in the history

  9. chore: drop duplicate file

    @Chris-Hibbert @mhofman
    Chris-Hibbert authored and mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    dfe4d21 View commit details
    Browse the repository at this point in the history

  10. ci: test wallet-factory core proposal

    @mhofman
    mhofman committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    d58948e View commit details
    Browse the repository at this point in the history