Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(time): docs for types are in .d.ts #9214

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

dckc
Copy link
Member

@dckc dckc commented Apr 9, 2024

refs:

Documentation Considerations

fix typedoc config to find the bulk of the @agoric/time docs

@dckc dckc requested a review from turadg April 9, 2024 22:15
@@ -4,6 +4,6 @@
],
"entryPoints": [
"src/timeMath.js",
"src/types.js"
"src/types.d.ts"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah so it's the actual filename, not the module specifier

@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Apr 9, 2024
@dckc
Copy link
Member Author

dckc commented Apr 9, 2024

???

lerna notice 
lerna ERR! E503 one of the uplinks is down, refuse to publish

https://github.com/Agoric/agoric-sdk/actions/runs/8623017681/job/23635370372?pr=9214#step:6:1485

I expect it's a flake; here's hoping...

@dckc dckc added the bypass:integration Prevent integration tests from running on PR label Apr 9, 2024
@mergify mergify bot merged commit 2aba395 into master Apr 9, 2024
72 of 74 checks passed
@mergify mergify bot deleted the dc-time-doc-include branch April 9, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge bypass:integration Prevent integration tests from running on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants