Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat with Endo on Yarn 4 #9290

Merged
merged 1 commit into from
Apr 26, 2024
Merged

compat with Endo on Yarn 4 #9290

merged 1 commit into from
Apr 26, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Apr 26, 2024

refs: #451
refs: #9209

Description

We need agoric-sdk's integration tests to work with Endo running Yarn 4. #9285 tested against endojs/endo#2222. This PR is to land the necessary changes in master so the Endo PR can land without breaking SDK CI.

This helps with #9209 and is a subset of #9286 , all that we need for Endo right now.

Security Considerations

none

Scaling Considerations

none, build time

Documentation Considerations

Nothing for SDK

Testing Considerations

CI

Upgrade Considerations

n/a

@turadg turadg requested review from kriskowal and michaelfig April 26, 2024 16:19
@kriskowal kriskowal added the force:integration Force integration tests to run on PR label Apr 26, 2024
@kriskowal
Copy link
Member

Thank you for proving these can land ahead of the Endo changes! I added the force:integration label.

Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending integration test verification.

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Apr 26, 2024
@mergify mergify bot merged commit 203d4d7 into master Apr 26, 2024
79 of 86 checks passed
@mergify mergify bot deleted the 451-endo-yarn branch April 26, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants