Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(restore-node): corepack enable to accommodate Endo #9306

Merged
merged 1 commit into from
Apr 30, 2024
Merged

ci(restore-node): corepack enable to accommodate Endo #9306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/restore-node/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ runs:
${{ inputs.path }}/endo-sha.txt
- uses: kenchan0130/actions-system-info@master
id: system-info
- run: corepack enable
shell: bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right place for corepack enable. I wish I'd thought of it when adding https://github.com/Agoric/agoric-sdk/blob/master/.github/workflows/integration.yml#L247

I think we can remove the latter. Also I don't think the shell property is necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the latter.

Done.

Also I don't think the shell property is necessary.

I've found that shell: bash is necessary for every run: xxx step because restore-node/action.yml is a composite action, not a workflow. See the Github documentation that describes shell: in the composite actions metadata syntax section.

- name: restore built files
id: built
uses: actions/cache@v4
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,7 @@ jobs:
ignore-endo-branch: 'true'
id: restore-node
- name: setup a3p-integration
run: |
corepack enable
yarn install
run: yarn install
working-directory: a3p-integration
- name: verify SDK image didn't change
# In the future when we can rebuild the SDK image with resolved endo packages, it would
Expand Down
Loading