Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: withdrawReward on StakingAccountHolder #9307

Merged
merged 3 commits into from
May 3, 2024
Merged

feat: withdrawReward on StakingAccountHolder #9307

merged 3 commits into from
May 3, 2024

Commits on May 3, 2024

  1. feat: WithdrawReward on StakingAccountHolder 

     - test: withdrawReward on StakingAccountHolder.helpers facet
 - test tx encoding layers
 - test non-trivial delegations
 - factor out tryDecodeResponse, toJSON
 - todos for remaining work
    @dckc
    dckc committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8cbe1b6 View commit details
    Browse the repository at this point in the history

  2. feat(cosmic-proto): export distribution 

    UNTIL endojs/endo#2265
    @dckc
    dckc committed May 3, 2024
    Configuration menu
    Copy the full SHA
    17c2932 View commit details
    Browse the repository at this point in the history

  3. refactor: refine StakingAccountHolder facets 

     - implement delegate() etc. directly on holder;
   - avoids unguarded helper methods
   - since these methods don't have multiple callers,
     it makes little sense to put them on the helper facet anyway
 - call zcf.makeInvitation() directly from invitationMaker facet
   methods; prune makeXInvitation methods on holder
    @dckc
    dckc committed May 3, 2024
    Configuration menu
    Copy the full SHA
    aa79cd5 View commit details
    Browse the repository at this point in the history