cosmic-proto export patterns

[turadg]

refs: #9307

Description

Simplify codegen exports using exports subpath patterns

Reviewers,

• should the exported path have .js?
• should Agoric exports be under agoric like the others?

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	2c3b233
Status:	✅  Deploy successful!
Preview URL:	https://e36524de.agoric-sdk.pages.dev
Branch Preview URL:	https://ta-proto-wildcard.agoric-sdk.pages.dev

View logs

.

[0xpatrickdev]

@turadg 🎉 LGTM - i am going to apply a small patch as I'd like to depend on this.

--- a/packages/cosmic-proto/test/test-vatsafe.js
+++ b/packages/cosmic-proto/test/test-vatsafe.js
@@ -3,7 +3,7 @@
 import test from '@endo/ses-ava/prepare-endo.js';
 import { cosmos } from '@agoric/cosmic-proto';

-import { MsgDelegate } from '@agoric/cosmic-proto/cosmos/staking/v1beta1/tx';
+import { MsgDelegate } from '@agoric/cosmic-proto/cosmos/staking/v1beta1/tx.js';

 // @ts-expect-error
 cosmos.staking.v1beta1.MsgDelegate.missing;

--- a/packages/boot/test/bootstrapTests/test-vat-orchestration.ts
+++ b/packages/boot/test/bootstrapTests/test-vat-orchestration.ts
@@ -6,7 +6,7 @@ import {
  MsgDelegate,
  MsgDelegateResponse,
} from '@agoric/cosmic-proto/cosmos/staking/v1beta1/tx.js';
-import { Any } from '@agoric/cosmic-proto/google/protobuf/any';
+import { Any } from '@agoric/cosmic-proto/google/protobuf/any.js';
import type { ChainAccount, OrchestrationService } from '@agoric/orchestration';
import { decodeBase64 } from '@endo/base64';
import { M, matches } from '@endo/patterns';

[michaelfig]

To answer your posed questions, yes, please also export dist/codegen/agoric as /agoric/* (but do not yet remove the lifted swingset, vstorage, etc), and yes, please use the .js suffix on the exports.

[michaelfig]

Should ./vatsafe get the same treatment?

"./vatsafe/*.js": {
  "types": "./dist/codegen/vatsafe/*.d.ts",
  "default": "./dist/codegen/vatsafe/*.js"
}

[turadg]

it's meant to be one module

[michaelfig]

I approved, but removed the automerge:rebase so that you get a chance to address comments before putting this PR back on the merge train.

[kriskowal]

Thanks for the issue and work-around for the current Endo bundler limitation, and thanks for documenting in package.json.md. That could be A Thing™.