Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(async-flow): simplify with zonified vow #9336

Merged
merged 3 commits into from
May 14, 2024

Conversation

erights
Copy link
Member

@erights erights commented May 8, 2024

Staged on #9097

closes: #XXXX
refs: #9231 #9321 #9329 #9097

Description

Now that watchPromise is abstracted over zones and vows make use of that, we can simplify the test cases a lot.

Should be a pure refactor with no externally observable effect.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

tests simpler. Otherwise, none

Upgrade Considerations

none

@erights erights self-assigned this May 8, 2024
Copy link

cloudflare-workers-and-pages bot commented May 8, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2d32d1e
Status:⚡️  Build in progress...

View logs

@erights erights requested review from mhofman and michaelfig May 8, 2024 04:20
@erights erights marked this pull request as ready for review May 8, 2024 04:20
@erights erights force-pushed the markm-async-flow branch 2 times, most recently from 596304e to 4cb7ed6 Compare May 8, 2024 23:24
@erights erights force-pushed the markm-zonify-vowTools branch 2 times, most recently from f40cf7e to a0198f0 Compare May 8, 2024 23:39
@erights erights mentioned this pull request May 10, 2024
3 tasks
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and mechanical.

@erights erights merged commit da7462c into markm-async-flow May 14, 2024
18 of 19 checks passed
@erights erights deleted the markm-zonify-vowTools branch May 14, 2024 18:32
erights added a commit that referenced this pull request May 16, 2024
Staged on #9097

closes: #XXXX
refs: #9231 #9321 #9329 #9097

## Description

Now that `watchPromise` is abstracted over zones and vows make use of
that, we can simplify the test cases a lot.

Should be a pure refactor with no externally observable effect.

### Security Considerations

none
### Scaling Considerations

none
### Documentation Considerations

none
### Testing Considerations

tests simpler. Otherwise, none
### Upgrade Considerations

none
@erights erights added the asyncFlow related to membrane-based replay and upgrade of async functions label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asyncFlow related to membrane-based replay and upgrade of async functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants