Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare upgrade-16 branch #9444

Closed
wants to merge 6 commits into from
Closed

Conversation

iomekam
Copy link
Contributor

@iomekam iomekam commented Jun 3, 2024

Description

Bumps the upgrade handler in preparation of upgrade-16.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

A new release will be created from this which will contain the usual documentation

Testing Considerations

a3p integration tests bumped

Upgrade Considerations

Next chain software upgrade

Copy link

cloudflare-workers-and-pages bot commented Jun 3, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4c47b0
Status: ✅  Deploy successful!
Preview URL: https://51042d06.agoric-sdk.pages.dev
Branch Preview URL: https://ikenna-init-upgrade-16-2.agoric-sdk.pages.dev

View logs

@iomekam iomekam force-pushed the ikenna-init-upgrade-16-2 branch 2 times, most recently from 93f4f89 to 9113d5f Compare June 3, 2024 15:21
@iomekam iomekam changed the base branch from master to dev-upgrade-16 June 3, 2024 20:32
@iomekam iomekam marked this pull request as ready for review June 4, 2024 03:40
@iomekam iomekam requested a review from mhofman June 4, 2024 04:12
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding handler name changes need to be done in a3p-integration

@mhofman mhofman added the force:integration Force integration tests to run on PR label Jun 4, 2024
@iomekam iomekam force-pushed the ikenna-init-upgrade-16-2 branch 5 times, most recently from daea601 to b1c84c2 Compare June 6, 2024 16:08
@iomekam iomekam requested a review from mhofman June 6, 2024 17:01
@mhofman
Copy link
Member

mhofman commented Jun 14, 2024

I don't think any of the core proposals should be removed from the handler. I believe all the ones there are slated for upgrade-16

@iomekam iomekam force-pushed the ikenna-init-upgrade-16-2 branch 3 times, most recently from 5a26ba3 to 9bced72 Compare June 18, 2024 18:51
@iomekam iomekam marked this pull request as draft June 18, 2024 19:00
@iomekam iomekam marked this pull request as ready for review June 20, 2024 20:34
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues cropped up because of the rebase. Sorry about that

Comment on lines -6 to -8
network: { incarnation: 0 },
ibc: { incarnation: 0 },
localchain: { incarnation: 0 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should stay in

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is coming from the rebase. Please remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please maintain this file and others

@mhofman
Copy link
Member

mhofman commented Jun 22, 2024

Superseded by #9565

@mhofman mhofman closed this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants