Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify CoreEval vs proposal #9468

Merged
merged 7 commits into from
Jun 9, 2024
Merged

clarify CoreEval vs proposal #9468

merged 7 commits into from
Jun 9, 2024

Commits on Jun 9, 2024

  1. chore(types): s/ProposalBuilder/CoreEvalBuilder 

    more accurate. What's built is a code/permit pair (and its bundles), not a proposal (which has a title and a list of core evals)
    @turadg
    turadg committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    09fe78c View commit details
    Browse the repository at this point in the history

  2. chore: s/writeCoreProposal/writeCoreEval

    @turadg
    turadg committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    9349c1d View commit details
    Browse the repository at this point in the history

  3. chore: s/writeCoreProposal/writeCoreEval

    @turadg
    turadg committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    03c6382 View commit details
    Browse the repository at this point in the history

  4. refactor: remove Proposal terminology

    @turadg
    turadg committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    f6b46c5 View commit details
    Browse the repository at this point in the history

  5. refactor: rename writeCoreEvalParts for clarity

    @turadg
    turadg committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    5c93775 View commit details
    Browse the repository at this point in the history

  6. chore(types): define CoreEvalDescriptor

    @turadg
    turadg committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    16ca97e View commit details
    Browse the repository at this point in the history

  7. refactor: naming

    @turadg
    turadg committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    593361d View commit details
    Browse the repository at this point in the history