Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(vtransfer): transfer interceptor updates #9470

Merged
merged 1 commit into from
Jun 10, 2024
Merged

refactor(vtransfer): transfer interceptor updates #9470

merged 1 commit into from
Jun 10, 2024

Conversation

gibson042
Copy link
Member

@gibson042 gibson042 commented Jun 7, 2024 •
edited by michaelfig
Loading

@gibson042 gibson042 requested a review from michaelfig June 7, 2024 18:09
@gibson042 gibson042 added the force:integration Force integration tests to run on PR label Jun 7, 2024
@gibson042 gibson042 mentioned this pull request Jun 7, 2024
Merged
@gibson042 gibson042 changed the title [DO NOT MERGE] Dummy PR to test an extension of #8624 [DO NOT MERGE] Dummy PR to test #8624 vtransfer interceptor refactor Jun 7, 2024
@gibson042 gibson042 force-pushed the gibson-9059-vtransfer-interceptor-refactor branch from eae42f5 to e2d16f1 Compare June 7, 2024 18:36
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jun 7, 2024 •
edited
Loading

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8d11989
Status: ✅  Deploy successful!
Preview URL: https://96694596.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-9059-vtransfer-interc.agoric-sdk.pages.dev

View logs

@gibson042 gibson042 force-pushed the gibson-9059-vtransfer-interceptor-refactor branch 2 times, most recently from f33c681 to d720fe0 Compare June 7, 2024 18:55
@michaelfig michaelfig changed the title [DO NOT MERGE] Dummy PR to test #8624 vtransfer interceptor refactor refactor(vtransfer): transfer interceptor updates Jun 10, 2024
@michaelfig michaelfig force-pushed the gibson-9059-vtransfer-interceptor-refactor branch from d720fe0 to 8d11989 Compare June 10, 2024 17:09
michaelfig
michaelfig approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! LGTM.

@michaelfig michaelfig added automerge:no-update (expert!) Automatically merge without updates and removed force:integration Force integration tests to run on PR labels Jun 10, 2024
@michaelfig michaelfig mentioned this pull request Jun 10, 2024
Closed
@mergify mergify bot merged commit 0960242 into master Jun 10, 2024
70 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
automerge:no-update (expert!) Automatically merge without updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gibson042 @michaelfig