test(async-flow): demonstrate #9465 #9474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
76e7433
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6df4e867.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-asyncflow-test-early-c.agoric-sdk.pages.dev |
mhofman
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #9465
Description
This PR just captures the test from #9465 , turning it into an expected failure. A later PR that fixes the bug would then remove the
.failing.Security Considerations
The bug itself endangers integrity, so fixing it will help security. This PR though just adds the test that demonstrates the bug.
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
The point.
Upgrade Considerations
The bug means that an asyncFlow activation that does return early would be committed to the done state, preventing a later upgrade from repairing it to get beyond the problem. But this PR just adds the test for that bug.