Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump typescript-eslint #9479

Merged
merged 5 commits into from
Jul 6, 2024
Merged

bump typescript-eslint #9479

merged 5 commits into from
Jul 6, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Jun 10, 2024

evergreen

Description

Extracted from #9476 because that's blocked on a potential TS bug.

Bumps https://typescript-eslint.io/ to latest.

They deprecated ts-prefer-expect-error so I migrated the config to the new way.

It also added an allowForKnownSafePromises option to no-floating-promises but I don't see any compelling uses for that.

Security Considerations

none, lint

Scaling Considerations

none, lint

Documentation Considerations

none

Testing Considerations

CI

Upgrade Considerations

none, lint

@turadg turadg requested a review from mhofman June 10, 2024 17:42
Copy link

cloudflare-workers-and-pages bot commented Jun 10, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7f4d952
Status: ✅  Deploy successful!
Preview URL: https://2152bd64.agoric-sdk.pages.dev
Branch Preview URL: https://ta-bump-tslint.agoric-sdk.pages.dev

View logs

Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suspicious that we have 2 versions of eslint-plugin (7.12.0 & 7.7.1).

Conditional approval based on trying to figure out where the old one still comes from and get rid of it if possible.

yarn.lock Outdated
natural-compare "^1.4.0"
ts-api-utils "^1.3.0"

"@typescript-eslint/[email protected]":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out what still pulls 7.7.1. It doesn't seem referenced anywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed another yarn install after the dedupe

@turadg turadg force-pushed the ta/bump-tslint branch 2 times, most recently from e6a3d15 to d910811 Compare June 13, 2024 19:31
@turadg turadg mentioned this pull request Jun 13, 2024
mergify bot added a commit that referenced this pull request Jun 20, 2024
refs: #9152 

## Description

Typescript 5.5: https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-rc/

(an earlier push also had #9479 but I moved the commits out)

### Security Considerations

n/a, linting

### Scaling Considerations

n/a, linting


### Documentation Considerations

none

### Testing Considerations

none

### Upgrade Considerations

n/a, linting
mhofman pushed a commit that referenced this pull request Jun 20, 2024
refs: #9152 

## Description

Typescript 5.5: https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-rc/

(an earlier push also had #9479 but I moved the commits out)

### Security Considerations

n/a, linting

### Scaling Considerations

n/a, linting


### Documentation Considerations

none

### Testing Considerations

none

### Upgrade Considerations

n/a, linting
mhofman pushed a commit that referenced this pull request Jun 22, 2024
refs: #9152 

## Description

Typescript 5.5: https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-rc/

(an earlier push also had #9479 but I moved the commits out)

### Security Considerations

n/a, linting

### Scaling Considerations

n/a, linting


### Documentation Considerations

none

### Testing Considerations

none

### Upgrade Considerations

n/a, linting
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Jul 6, 2024
@mergify mergify bot merged commit 2c28414 into master Jul 6, 2024
80 of 85 checks passed
@mergify mergify bot deleted the ta/bump-tslint branch July 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants