feat(orchestrator): return unwrapped vows #9537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
force-pushed
the
pc/orchestrator-unwrapped-vows
branch
from
ae9ecf5
to
b3802fc
Compare
Deploying agoric-sdk with
|
| Latest commit: |
94d0c3c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76bd3baa.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-orchestrator-unwrapped-vo.agoric-sdk.pages.dev |
turadg
requested changes
Jun 19, 2024
| @@ -50,44 +51,89 @@ export const OrchestratorI = M.interface('Orchestrator', { | |||
| * orchestrationService: Remote<OrchestrationService>; | |||
| * storageNode: Remote<StorageNode>; | |||
| * timerService: Remote<TimerService>; | |||
| * vowTools: VowTools; | |||
| * zcf: ZCF; | |||
| * }} powers | |||
| */ | |||
| export const prepareOrchestrator = ( | |||
There was a problem hiding this comment.
this is now a kit. prepareOrchestratorKit.
but no consumers need these other facets so the module should still export a prepareOrchestrator that returns a makeOrchestrator that returns just its orchestrator facet
packages/orchestration/src/facade.js
Outdated
Comment on lines
95
to
98
| const orc = makeOrchestrator().orchestrator; | ||
|
|
||
| return async (...args) => fn(orc, ctx, ...args); |
There was a problem hiding this comment.
this shouldn't have access to the whole kit (per above).
turadg
force-pushed
the
pc/orchestrator-unwrapped-vows
branch
from
b3802fc
to
5b3d56e
Compare
turadg
approved these changes
Jun 19, 2024
- returning unwrapped vows to ensure tests are passing and functionality is preserved
0xpatrickdev
force-pushed
the
pc/orchestrator-unwrapped-vows
branch
from
5b3d56e
to
94d0c3c
Compare
0xpatrickdev
added
the
asyncFlow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9449
Description
Returns unwrapped vows in
Orchestrator(makeLocalAccount,getChain).