9449 chain facades return vows #9547
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
f9b6857
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d80d363.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9449-chain-facades.agoric-sdk.pages.dev |
| // FIXME use watch() from vowTools | ||
| return watch(allVows([icaP, V(icaP).getAddress()]), { |
There was a problem hiding this comment.
Why not destructure from L42 and wrap the watcher in a Far?
There was a problem hiding this comment.
Because I want it to be more likely to fail in testing.
turadg
added
automerge:rebase
In const vowTools = prepareVowTools(zone.subZone('vows'));Do we not pass them around to the relevant places? |
They're available. See https://github.com/Agoric/agoric-sdk/pull/9547/files#r1648321242 |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
| orchestration, | ||
| storageNode, | ||
| timer, | ||
| vowTools: { allVows }, |
There was a problem hiding this comment.
If we get watch from these vowTools, it'll make durable vows, right?
| @@ -1,13 +1,14 @@ | |||
| /** @file ChainAccount exo */ | |||
| import { makeTracer } from '@agoric/internal'; | |||
| import { V } from '@agoric/vow/vat.js'; | |||
| import { V, watch } from '@agoric/vow/vat.js'; | |||
There was a problem hiding this comment.
How about getting watch from the durable vowTools? See below.
| omni.makeAccount(), | ||
| agoric.makeAccount(), | ||
| // XXX when() until membrane | ||
| when(omni.makeAccount()), |
There was a problem hiding this comment.
The vowTools from the call to provideOrchestration are durable, right? How about getting when from there?
| @@ -4,6 +4,7 @@ import { withdrawFromSeat } from '@agoric/zoe/src/contractSupport/zoeHelpers.js' | |||
| import { Far } from '@endo/far'; | |||
| import { deeplyFulfilled } from '@endo/marshal'; | |||
| import { M, objectMap } from '@endo/patterns'; | |||
| import { when } from '@agoric/vow/vat.js'; | |||
| @@ -1,5 +1,5 @@ | |||
| /** @file ChainAccount exo */ | |||
| import { V } from '@agoric/vow/vat.js'; | |||
| import { V, watch } from '@agoric/vow/vat.js'; | |||
There was a problem hiding this comment.
again, a durable version is reasonably handy...
| makeLocalOrchestrationAccountKit, | ||
| localchain, | ||
| storageNode, | ||
| vowTools: { allVows }, |
There was a problem hiding this comment.
a durable watch is available in these vowTools, right?
turadg
force-pushed
the
9449-chain-facades
branch
from
a260b71
to
f9b6857
Compare
refs: #9449
Description
More exos returning vows. Note these are heap vows due to
agoric-sdk/packages/vow/vat.js
Lines 29 to 31 in 944adea
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
none