fix(scripts): Update GitHub release template to document recursive git clean
#9634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
01383ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://70addf3e.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-07-gen-github-re.agoric-sdk.pages.dev |
mhofman
reviewed
Jul 1, 2024
scripts/gen-github-release.sh
Outdated
| @@ -156,7 +156,7 @@ Install supported versions of Go, Node.js, and a compiler such as gcc or clang a | |||
| cd agoric-sdk | |||
| git fetch --all | |||
| git checkout $TAG | |||
| git clean -xdf | |||
| git clean -xdf && git submodule foreach --recursive git clean -xdf | |||
| yarn install | |||
There was a problem hiding this comment.
We need to switch to .bin/agd build as well.
And there are other changes I had to make in the release notes, some regarding the upgrade handler name, and some due to state-sync changes.
mhofman
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
@gibson042 please review my changes and merge as you see fit.
…it clean` Fixes #9633 Also fixes a reference to the script to include its file extension.
Add information regarding known issues with nvm and Node versions
gibson042
force-pushed
the
gibson-2024-07-gen-github-release
branch
from
51afbb2
to
01383ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9633
refs: #9614
Description
Adds
git submodule foreach --recursive git clean -xdfto build instructions in the release template.Security Considerations
None.
Scaling Considerations
n/a
Documentation Considerations
This PR updates documentation intended for node operators.
Testing Considerations
n/a
Upgrade Considerations
n/a