feat: add UpdateValidator and CancelAutoStake invitations to auto-stake-it #9786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds an example of extending a 'prepareSomeHolderKit' with extra invitation makers
- adds opts?: { extraInvitationMakerGuards, extraInvitationMakerMethods, extraStateShape } as third argument to facilitate this
Co-authored-by: Mark S. Miller <[email protected]>
Deploying agoric-sdk with
|
| Latest commit: |
e6adef2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2729aea9.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-portfolio-holder-kit-exte.agoric-sdk.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #9042
Description
While the title includes the primary changes, this was also a side-quest to explore patterns for object composition with exos. Here, an opts bag is added to
preparePortfolioHolderthat allows the caller to supply extra invitation methods. This pattern seems useful as it allows developers to easily add new functionality to an existing kit while ensuring safety-critical invitations (i.e. Transfer or Withdraw funds) are still available to the end wallet user.To Do
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations