feat: restake example contract #9821
Draft
+523
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
7e01722
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af760719.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9796-restake-continuing-invs.agoric-sdk.pages.dev |
0xpatrickdev
force-pushed
the
9796-restake-continuing-invs
branch
2 times, most recently
from
12d8122
to
548878b
Compare
| * }} RestakeParams | ||
| */ | ||
|
|
||
| export const restakeInvitaitonGuardShape = { |
Comment on lines
223
to
227
| const { delay, interval } = opts; | ||
| delay >= minimumDelay || | ||
| Fail`delay must be at least ${minimumDelay}`; | ||
| interval >= minimumInterval || | ||
| Fail`interval must be at least ${minimumInterval}`; |
There was a problem hiding this comment.
Is there a reason not to use TimeMath here?
There was a problem hiding this comment.
No - thanks for bringing it to attention. The latest plan for #9796 doesn't seem to depend on this PR, but will make sure to use TimeMath when this PR is picked up again.
turadg
force-pushed
the
9796-restake-continuing-invs
branch
from
548878b
to
d56616a
Compare
0xpatrickdev
commented
Sep 3, 2024
Comment on lines
215
to
222
| mustMatch( | ||
| validator, | ||
| ChainAddressShape, | ||
| 'invalid validator address', | ||
| ); | ||
| mustMatch(opts, RepeaterOptsShape, 'invalid repeater options'); |
There was a problem hiding this comment.
Suggested change
| mustMatch( | |
| validator, | |
| ChainAddressShape, | |
| 'invalid validator address', | |
| ); | |
| mustMatch(opts, RepeaterOptsShape, 'invalid repeater options'); |
covered by interface guard
mergify bot
added a commit
that referenced
this pull request
Sep 6, 2024
closes: #9796 ## Description Demonstrates a pattern for creating continuing invitations that have handlers written as orchestration flows. Builds upon the combine-invitation-makers from #9821 ### Security Considerations None ### Scaling Considerations Augmenting an existing exo's invitationMaker requires two new ones: the exo holding the other makers and an exo to wrap them both. ### Documentation Considerations Once this lands it should have an explicit tutorial for developers needing this functionality. ### Testing Considerations new tests ### Upgrade Considerations not yet deployed
- A contract that allows calls to make an OrchestrationAccount, and subsequently schedule a restake (claim and stake rewards) on an interval. - Leverages existing invitation makers like Delegate and combines them with Restake and CancelRestake.
0xpatrickdev
force-pushed
the
9796-restake-continuing-invs
branch
from
d56616a
to
9e7e377
Compare
- interact with timerService and repeater in `contract` context (using E, promises) - invoke flow in wake handler
0xpatrickdev
force-pushed
the
9796-restake-continuing-invs
branch
from
9e7e377
to
582993c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #9796
Description
Currently: a working restake contract that we'd like to refactor to use async-flow for continuing invitations (versus the current
restake.kit.jsmethods which use vowTools)Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations