improve slow-deletion runPolicy cleanup budget API #9880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
warner/8928-cleanup-budget
branch
from
03a217c
to
2df67a3
Compare
Deploying agoric-sdk with
|
| Latest commit: |
8b93c2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9820fb07.agoric-sdk.pages.dev |
| Branch Preview URL: | https://warner-8928-cleanup-budget.agoric-sdk.pages.dev |
warner
force-pushed
the
warner/8928-cleanup-budget
branch
from
2df67a3
to
0dcb2e4
Compare
warner
force-pushed
the
warner/7212-retire-abandoned-unreachables
branch
2 times, most recently
from
6813383
to
aa004f9
Compare
warner
force-pushed
the
warner/8928-cleanup-budget
branch
from
0dcb2e4
to
9a8ec7f
Compare
warner
force-pushed
the
warner/7212-retire-abandoned-unreachables
branch
from
aa004f9
to
2a10c9d
Compare
warner
force-pushed
the
warner/8928-cleanup-budget
branch
from
9a8ec7f
to
18f4e6c
Compare
warner
force-pushed
the
warner/7212-retire-abandoned-unreachables
branch
from
2a10c9d
to
9dcdabb
Compare
warner
force-pushed
the
warner/8928-cleanup-budget
branch
from
18f4e6c
to
556953f
Compare
Base automatically changed from
warner/7212-retire-abandoned-unreachables
to
master
August 14, 2024 18:43
gibson042
approved these changes
Aug 14, 2024
warner
force-pushed
the
warner/8928-cleanup-budget
branch
from
556953f
to
77c7e47
Compare
warner
force-pushed
the
warner/8928-cleanup-budget
branch
from
77c7e47
to
db0111b
Compare
This will make life easier for the upcoming swingset change, where
`runPolicy.allowCleanups()` can return `{ default: Infinity }`.
warner
force-pushed
the
warner/8928-cleanup-budget
branch
from
db0111b
to
8b93c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
runPolicyAPIs that control slow vat deletion (runPolicy.allowCleanup()), and the reporting of cleanup results (.didCleanup()). The new API allows individual phases to get different budgets, so e.g. we can restrict the expensiveexportsandimportsphases to 5 deletions per run, while letting the cheaperkvphase to do 50 per run, so overall deletion happens faster. Experiments show this should allow our old large price-feed vats to be deleted in about 5 months, rather than 6 years.The swing-store deletion calls (
snapStore.deleteVatSnapshots(budget)andtranscriptStore.deleteVatTranscripts(budget)) were changed to acceptbudget = Infinity, and use Infinity as a default, to allow swingset to use Infinity in policies. This seems less error-prone than usingundefinedto mean "unlimited".See run-policy.md for the new API and examples of how a host application should use it.
refs #8928