upgrade Yarn to v4 #9945
Draft
upgrade Yarn to v4 #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
fd40918
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87ef4d83.agoric-sdk.pages.dev |
| Branch Preview URL: | https://451-yarn-4.agoric-sdk.pages.dev |
turadg
force-pushed
the
451-yarn-4
branch
2 times, most recently
from
ed72865
to
3e004b5
Compare
dckc
approved these changes
Aug 22, 2024
.gitignore
Outdated
| @@ -42,8 +42,14 @@ typings/ | |||
| # Output of 'npm pack' | |||
| *.tgz | |||
|
|
|||
| # Yarn Integrity file | |||
| .yarn-integrity | |||
| # Yarn (https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored) | |||
| "lint": "run-s --continue-on-error lint:*", | ||
| "lint:eslint": "eslint .", | ||
| "lint:types": "tsc" | ||
| "lint": "yarn run -T run-s --continue-on-error 'lint:*'", |
There was a problem hiding this comment.
TIL:
-T,--top-level Check the root workspace for scripts and/or binaries instead of the current one
turadg
force-pushed
the
451-yarn-4
branch
2 times, most recently
from
fe462a3
to
7709da3
Compare
turadg
force-pushed
the
451-yarn-4
branch
3 times, most recently
from
47b9336
to
4c01efe
Compare
kriskowal
approved these changes
Aug 23, 2024
| const cliEntrypoint = await importMetaResolve( | ||
| 'agoric/src/entrypoint.js', | ||
| import.meta.url, | ||
| ).then(u => new URL(u).pathname); |
There was a problem hiding this comment.
Generally favor url.fileURLToPath for portability.
There was a problem hiding this comment.
I lean toward createRequire
import { createRequire } from 'node:module';
const require = createRequire(import.meta.url);| @@ -47,6 +47,7 @@ The parent and child communicate using "commands". | |||
|
|
|||
|  | |||
|
|
|||
| <!-- FIXME this stopped working some time ago (was never in CI) | |||
| @@ -26,6 +26,7 @@ Then for the couple deeper packages | |||
| yarn lerna exec --concurrency 1 --no-bail '../../../scripts/migrate-test-names.mjs' | |||
|
|
|||
| `; | |||
| console.log(usage); | |||
There was a problem hiding this comment.
Seems odd to log usage on the happy path.
There was a problem hiding this comment.
agreed. it was expedient to fix a lint error that usage isn't ever used.
`yarn global add` is no longer supported. Yarn is just for managing project dependencies. NPM is recommended for global path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #451
#loadgen-branch: ta/yarn4-compat
Description
Attempting #8461 again after various other packageManager improvements. Starting with a fresh branch to be able to compare with the earlier attempt.
This time I'm deferring adoption of the workspace protocol to avoid having to test publishing (for all but
bootpackage which is private)Security Considerations
None. Though Yarn 4 opens the option to keep the registry cache in the repo, reducing supply chain risk.
Scaling Considerations
n/a
Documentation Considerations
Any docs that advise a global install of Yarn will need updating. We should only be advising
corepack enableso that thepackageManagerfield can specify the correct version.Testing Considerations
CI
Upgrade Considerations
n/a