Making dapp work on GHCS #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amessbee
requested review from
dckc,
toliaqat,
frazarshad,
rabi-siddique and
Jovonni
dckc
reviewed
Jul 6, 2024
| @@ -45,6 +45,7 @@ export const makeHttpClient = (url, fetch) => { | |||
| execute: async request => { | |||
| const settings = { | |||
| method: 'POST', | |||
| mode: 'no-cors', | |||
There was a problem hiding this comment.
Is no-cors a reasonable thing to use in all circumstances? What are the security considerations?
|
How do I test it? |
rabi-siddique
force-pushed
the
ms/making-agoric-basic-on-GHCS
branch
from
7e8c54c to
e73546f
Compare
rabi-siddique
force-pushed
the
ms/making-agoric-basic-on-GHCS
branch
3 times, most recently
from
9aec24d to
97c4db9
Compare
|
by way of motivation / rationale, I added a link in the description to please make sure each PR includes justification; typically by way of a reference to an issue cc @toliaqat |
toliaqat
reviewed
Jul 8, 2024
toliaqat
reviewed
Jul 8, 2024
.devcontainer.json
Outdated
| "onAutoForward": "silent" | ||
| } | ||
| }, | ||
| "postStartCommand": "bash -i -c 'nvm install 18.20 && nvm alias default 18.20' && bash ./make_ports_public.sh 5173 1317 26657" |
There was a problem hiding this comment.
@rabi-siddique @amessbee I think we need a lot of testing to sure ./make_ports_public.sh 5173 1317 26657 works every time. If there is flakyness then we should address it.
rabi-siddique
force-pushed
the
ms/making-agoric-basic-on-GHCS
branch
from
97c4db9 to
ea3e985
Compare
Removed '/' at the end of the address.
toliaqat
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=================
Instructions to run
dapp-agoric-basicin GHCSSeveral people asked therefore I am putting it at the top.
Codespacestab and create a new Codespace. If you are already using Codespaces on current repo then click the "+" button on top right of theCodespacestab to create a new one.yarn installin the terminal.yarn start:dockerfollowed byyarn docker:logs- kill it after you seebegin/commit.yarn start:contract.yarn start:ui- a pop-up should appear in bottom right. Click open in browser if needed.=================
refs:
Changes include (for now):
CODESPACE_NAMEfrom env and updates inApp.tsxmode: 'no-cors'to makeHttpClient.jsTODO:
We (@amessbee and @rabi-siddique ) checked SWAP and it should work as is at this point. WIP.