-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating-contract-agnostic-docker --WIP-- #58
base: main
Are you sure you want to change the base?
Conversation
@mujahidkay @rabi-siddique @frazarshad @usmanmani1122 @Muneeb147 Need your help to review and test the following on your machines and get feedback. Testing two dapps in tandem can be done as below:
|
"docker:bash": "docker compose exec agd bash", | ||
"docker:make": "docker compose exec agd make -C /workspace/contract", | ||
"docker:bash": "docker exec agd bash", | ||
"docker:make": "docker exec agd make -C /ws-agoric-basics/contract", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting approach!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idea: to manage namespace collisions, use an env variable with a default ${AG_CONTAINER:-agd}
and maybe for ws-agoric-basics
This is a twin of a PR in dapp-offer-up repo.
Goal of this PR is to (maybe partially) close #92. Currently running of
agoriclocal
chain and deploying and starting contract are intertwined in this dapp. This is somewhat unnatural as chain should not depend on the files of any specific contract - apart from the ones that designated essential for its running.Further, running a chain independent of a specific contract will allow testing of multiple dapp simultaneously running and interacting with each other which may unlock several scenarios that a developer may want to test for.
As per discussion with @toliaqat, here is a plan:
run-chain.sh
) that necessary tasks for running of chain independently.yarn start:contract
should handle most of the heavy work including:dapp-offer-up
here)Makefile
install-bundle
,submit-proposal
,vote
etc. calls.install-bundle
,submit-proposal
,vote
etc. calls needed to deploy and run the contract using scripts as before.agoric
andagd
CLI.Link to IBIS document.